-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the cache leak in yurtappoverrider controller #1795
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Welcome @MeenuyD! It looks like this is your first PR to openyurtio/openyurt 🎉 |
/rerun |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1795 +/- ##
==========================================
- Coverage 52.23% 52.16% -0.07%
==========================================
Files 172 172
Lines 20840 20840
==========================================
- Hits 10885 10872 -13
- Misses 8998 9010 +12
- Partials 957 958 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MeenuyD, rambohe-ch, YTGhost The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add Cache Cleanup and Update on Deletion and Changes
When a
YurtAppOverrider
instance is deleted, the cache data inCacheOverriderMap
should also be removed. This ensures that the cache stays synchronized with the actual instances.Additionally, when entries of
YurtAppOverrider
are changed, the controller now updates the new instance intoCacheOverriderMap
. This guarantees that the cache reflects the latest changes in theYurtAppOverrider
instances.#1793