Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the cache leak in yurtappoverrider controller #1795

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix the cache leak in yurtappoverrider controller #1795

merged 1 commit into from
Nov 15, 2023

Conversation

MeenuyD
Copy link
Contributor

@MeenuyD MeenuyD commented Nov 14, 2023

Add Cache Cleanup and Update on Deletion and Changes

When a YurtAppOverrider instance is deleted, the cache data in CacheOverriderMap should also be removed. This ensures that the cache stays synchronized with the actual instances.

Additionally, when entries of YurtAppOverrider are changed, the controller now updates the new instance into CacheOverriderMap. This guarantees that the cache reflects the latest changes in the YurtAppOverrider instances.
#1793

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Nov 14, 2023
@openyurt-bot
Copy link
Collaborator

Welcome @MeenuyD! It looks like this is your first PR to openyurtio/openyurt 🎉

@rambohe-ch
Copy link
Member

/rerun

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (068fefe) 52.23% compared to head (70f8cce) 52.16%.
Report is 2 commits behind head on master.

Files Patch % Lines
...er/yurtappoverrider/yurtappoverrider_controller.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
- Coverage   52.23%   52.16%   -0.07%     
==========================================
  Files         172      172              
  Lines       20840    20840              
==========================================
- Hits        10885    10872      -13     
- Misses       8998     9010      +12     
- Partials      957      958       +1     
Flag Coverage Δ
unittests 52.16% <75.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MeenuyD, rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Nov 15, 2023
@rambohe-ch rambohe-ch merged commit 15bd83b into openyurtio:master Nov 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants