Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use node-role.kubernetes.io/control-plane for yurt-manager node selection #1723

Merged

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Oct 5, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1721

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@YTGhost: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1721

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Oct 5, 2023
@openyurt-bot openyurt-bot requested review from Fei-Guo and qclc October 5, 2023 14:34
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1723 (b15787d) into master (424dcc2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1723   +/-   ##
=======================================
  Coverage   51.64%   51.64%           
=======================================
  Files         168      168           
  Lines       20063    20063           
=======================================
  Hits        10362    10362           
  Misses       8716     8716           
  Partials      985      985           
Flag Coverage Δ
unittests 51.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@YTGhost YTGhost force-pushed the feat-yurt-manager-node-selection branch from ee121f3 to b15787d Compare October 5, 2023 15:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Oct 8, 2023
@rambohe-ch
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yurt-manager should use node-role.kubernetes.io/control-plane for node selection.
3 participants