From 97b675ce29518fb31ab1a6aa92e01712e6803078 Mon Sep 17 00:00:00 2001
From: Vlad Vesa <vlad.vesa@outlook.com>
Date: Mon, 18 Mar 2024 13:11:10 +0200
Subject: [PATCH] Improve session handling while fetching vehicle blocks

---
 .../java/org/transitclock/service/VehiclesServiceImpl.java  | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/core/src/main/java/org/transitclock/service/VehiclesServiceImpl.java b/core/src/main/java/org/transitclock/service/VehiclesServiceImpl.java
index 9dabefe56..f622e9566 100644
--- a/core/src/main/java/org/transitclock/service/VehiclesServiceImpl.java
+++ b/core/src/main/java/org/transitclock/service/VehiclesServiceImpl.java
@@ -398,14 +398,12 @@ public Collection<IpcVehicle> getVehiclesForBlocks() {
     @Override
     public Collection<IpcVehicleToBlockConfig> getVehicleToBlockConfig(String blockId) {
         List<IpcVehicleToBlockConfig> result = new ArrayList<>();
-        Session session = HibernateUtils.getSession();
-        try {
+        try (Session session = HibernateUtils.getSession()){
             for (VehicleToBlockConfig vTBC : VehicleToBlockConfig.getVehicleToBlockConfigsByBlockId(session, blockId)) {
                 result.add(new IpcVehicleToBlockConfig(vTBC));
             }
-            session.close();
         } catch (Exception ex) {
-            session.close();
+            logger.error("Something happened while fetching the VehicleToBlockConfig.", ex);
         }
         return result;
     }