You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm trying to override some of the default tags that nginx-opentracing sets using opentracing_tag directives in my location blocks but it doesn't seem to work, is that expected?
If I modify the config to use different tag names then (as below) then they come through fine, but ideally I'd like to use http.host and http.url to allow better consistency between my services.
I'm trying to override some of the default tags that nginx-opentracing sets using
opentracing_tag
directives in mylocation
blocks but it doesn't seem to work, is that expected?I'm running:
Nginx: 1.13.6 (compiled from source)
OS: Ubuntu 16.04
nginx-opentracing: 0.9.0 (binary release)
The location blocks in my config look like so:
But when the span is sent I always see the default
http.host
andhttp.url
tags as defined in the source here: https://github.com/opentracing-contrib/nginx-opentracing/blob/master/opentracing/src/ngx_http_opentracing_module.cpp#L49-L56If I modify the config to use different tag names then (as below) then they come through fine, but ideally I'd like to use
http.host
andhttp.url
to allow better consistency between my services.Is there anything I can do to make this work currently? If not, does this seem like something that's worth a PR to change the behaviour?
The text was updated successfully, but these errors were encountered: