Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an image that can be used without customizing #127

Open
trajano opened this issue Apr 13, 2020 · 2 comments
Open

Provide an image that can be used without customizing #127

trajano opened this issue Apr 13, 2020 · 2 comments

Comments

@trajano
Copy link

trajano commented Apr 13, 2020

Is it possible to have a version of the image built so that it can be configured using environment variables rather than building a custom image?

@rnburn
Copy link
Collaborator

rnburn commented Apr 14, 2020

What options do you want to configure from environmental variables?

Keep in mind that by default nginx drops all the environmental variables when it forks a worker.
http://nginx.org/en/docs/ngx_core_module.html#env

@trajano
Copy link
Author

trajano commented Apr 14, 2020

OPENTRACING_ENDPOINT is basically the only one I can think of. That will allow the traces to go to a specific server. So the :zipkin image will go use the zipkin library vs :datadog or :jaeger

The reason for specific images is so that not all libraries will be loaded to support some IF-THEN-ELSE condition in the configuration file

  # Load a vendor tracer
  opentracing_load_tracer /usr/local/lib/libjaegertracing_plugin.so /etc/jaeger-nginx-config.json;

  # or 
  #   opentracing_load_tracer /usr/local/lib/liblightstep_tracer_plugin.so /path/to/config;
  # or 
  #   opentracing_load_tracer /usr/local/lib/libzipkin_opentracing_plugin.so /path/to/config;
  # or
  #   opentracing_load_tracer /usr/local/lib/libdd_opentracing_plugin.so /path/to/config;

A testcontainers integration test can be created to start up zipkin (or whatever backend server) and the nginx-with-opentracing:zipkin and make a http call for the home page to and then followed by a REST API query to zipkin server to see if the entry was added successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants