Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client span is finished before server span #78

Open
pavolloffay opened this issue Aug 30, 2018 · 4 comments
Open

Client span is finished before server span #78

pavolloffay opened this issue Aug 30, 2018 · 4 comments

Comments

@pavolloffay
Copy link
Collaborator

screenshot of jaeger ui

GET is a client request. get is a server span for that request. The server span should be finished before the client request.

cc @yurishkuro
@pavolloffay pavolloffay mentioned this issue Aug 30, 2018
Closed
@pavolloffay
Copy link
Collaborator Author

screenshot of zipkin - traces

Sleuth has the same behavior - server span is finished after the client span.

@wuyupengwoaini
Copy link

wuyupengwoaini commented Feb 15, 2019 •
edited
Loading

I found the same problem ,but I don't kown the real reason.Could you tell me the real reason
default

@pavolloffay
Copy link
Collaborator Author

  • the server filter is invoked after the request is closed
  • or the client filter is invoked before the request is closed

@wuyupengwoaini
Copy link

But I don't find any evidence to prove it.

could it jaegertracing/jaeger-client-java#192 maybe the reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Fix client span finishes before server pavolloffay/java-spring-web
2 participants
@pavolloffay @wuyupengwoaini