Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segment hash clarification & issue #27

Open
strantalis opened this issue Sep 18, 2023 · 0 comments
Open

segment hash clarification & issue #27

strantalis opened this issue Sep 18, 2023 · 0 comments
Labels
question Further information is requested

Comments

@strantalis
Copy link
Member

This is another spot where we seem to be double encoding with hex and base64 but the spec and the actual current implementations don't currently align again.

It seems that we are just extracting the gcm authentication tag off the cipher text then hex and base64 encoding it. Is this because its already a mac or should we be actually generating a sha256 hash from it?

I guess either way this needs some discussion as this is another place that we need to either update the implementations or the spec.

@strantalis strantalis added the question Further information is requested label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant