You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is another spot where we seem to be double encoding with hex and base64 but the spec and the actual current implementations don't currently align again.
It seems that we are just extracting the gcm authentication tag off the cipher text then hex and base64 encoding it. Is this because its already a mac or should we be actually generating a sha256 hash from it?
I guess either way this needs some discussion as this is another place that we need to either update the implementations or the spec.
The text was updated successfully, but these errors were encountered:
This is another spot where we seem to be double encoding with
hex
andbase64
but the spec and the actual current implementations don't currently align again.It seems that we are just extracting the gcm authentication tag off the cipher text then hex and base64 encoding it. Is this because its already a
mac
or should we be actually generating a sha256 hash from it?I guess either way this needs some discussion as this is another place that we need to either update the implementations or the spec.
The text was updated successfully, but these errors were encountered: