-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy: GetAttributesByValueFqns RPC request validation should happen in protovalidate rules #1651
Comments
After further discussion with @jakedoublev and @jrschumacher, we've decided the FQN |
…on to protovalidate (#1657) fix #1651 --------- Co-authored-by: Jake Van Vorhis <[email protected]> Co-authored-by: jakedoublev <[email protected]>
Background
Originally brought up in a separate PR: https://github.com/opentdf/platform/pull/1633/files/e34689983f9be1b52af49254f5ccfa7eb8baf5f9#r1801590942
The request validation checks at the beginning of the RPC method should be moved to protovalidate rules. Additionally, see comments below for other changes.
Acceptance Criteria
r.GetWithValue()
nil check and any existing protovalidate rules requiring it in the request, then add an optional comment on the request proto fieldfqns
array length check to protovalidate with a min and max items range of 1-250 (sensible default for now)The text was updated successfully, but these errors were encountered: