Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy: ListResourceMappingsByFullyQualifiedGroup db query should employ fewer roundtrips #1629

Open
ryanulit opened this issue Oct 10, 2024 · 0 comments
Open

Policy: ListResourceMappingsByFullyQualifiedGroup db query should employ fewer roundtrips #1629

ryanulit opened this issue Oct 10, 2024 · 0 comments
Labels
comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry)

Comments

@ryanulit
Copy link
Contributor

Background

Similar to #1357, the policy RPC ListResourceMappingsByGroupFqns calls an internal ListResourceMappingsByFullyQualifiedGroup function and SQL query to retrieve the mappings.

If multiple FQNs are provided, it roundtrips the DB for each individual FQN rather than employing a batch call.

Acceptance Criteria

  1. only a single roundtrip to the database is employed for the multiple value FQNs received in the RPC
  2. integration tests are updated
@jrschumacher jrschumacher added the comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrschumacher @ryanulit