Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info to entityID when extracted from token #1615

Closed
elizabethhealy opened this issue Oct 7, 2024 · 0 comments · Fixed by #1616
Closed

Add more info to entityID when extracted from token #1615

elizabethhealy opened this issue Oct 7, 2024 · 0 comments · Fixed by #1616
Assignees
@elizabethhealy

Comments

@elizabethhealy
Copy link
Member

elizabethhealy commented Oct 7, 2024 •
edited
Loading

Currently, when extracting entities from a token in ERS, they are named jwtentity-0 and jwtentity-1 in the entity chain. This can get confusing when trying to debug; especially for decisions triggered by kas. Add more info to the entity ID so admins know what entity is being referenced.
@elizabethhealy elizabethhealy mentioned this issue Oct 7, 2024
Merged
@elizabethhealy elizabethhealy self-assigned this Oct 7, 2024
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2024
@elizabethhealy
feat(authz): Add name to entity id when retrieved from token (#1616)
5304204 
resolves #1615
before: `jwtentity-0` or `jwtentity-1`
now includes more useful info in the entity name
```
       {
          "id": "jwtentity-0-clientid-tdf-entity-resolution-public",
          "client_id": "tdf-entity-resolution-public",
          "category": "CATEGORY_ENVIRONMENT"
        },
        {
          "id": "jwtentity-1-username-sample-user",
          "user_name": "sample-user",
          "category": "CATEGORY_SUBJECT"
        }
```
This is useful for parsing access decisions triggered by kas. Access
decisions only reference the entityID so, previously, it was be
difficult to know what entity it is referring to without looking through
the rest of the logs. This change should provide more context and save
debugging time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elizabethhealy elizabethhealy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(authz): Add name to entity id when retrieved from token opentdf/platform
1 participant
@elizabethhealy