Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated connection options #1498

Open
strantalis opened this issue Sep 3, 2024 · 1 comment
Open

remove deprecated connection options #1498

strantalis opened this issue Sep 3, 2024 · 1 comment
Labels
comp:sdk A software development kit, including library, for client applications and inter-service communicati Stale

Comments

@strantalis
Copy link
Member

During the deployment modes story we centralized around one custom grpc connection option.

platform/sdk/options.go

Lines 205 to 209 in 32c09c3

func WithCustomCoreConnection(conn *grpc.ClientConn) Option {
return func(c *config) {
c.coreConn = conn
}
}

This issue is to track removal of the following deprecated options.

platform/sdk/options.go

Lines 116 to 135 in 32c09c3

// Deprecated: Use WithCustomCoreConnection instead
func WithCustomPolicyConnection(conn *grpc.ClientConn) Option {
return func(c *config) {
c.coreConn = conn
}
}
// Deprecated: Use WithCustomCoreConnection instead
func WithCustomAuthorizationConnection(conn *grpc.ClientConn) Option {
return func(c *config) {
c.coreConn = conn
}
}
// Deprecated: Use WithCustomCoreConnection instead
func WithCustomEntityResolutionConnection(conn *grpc.ClientConn) Option {
return func(c *config) {
c.coreConn = conn
}
}

platform/sdk/options.go

Lines 174 to 178 in 32c09c3

func WithCustomWellknownConnection(conn *grpc.ClientConn) Option {
return func(c *config) {
c.coreConn = conn
}
}

Acceptance Criteria:

  • Update tests where needed
@strantalis strantalis added the comp:sdk A software development kit, including library, for client applications and inter-service communicati label Sep 3, 2024
@cassandrabailey293
Copy link
Contributor

we will probably need a custom connection for ERS once its split out. moving this ticket to next sprint once that is completed, we can work this one

@github-actions github-actions bot added the Stale label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:sdk A software development kit, including library, for client applications and inter-service communicati Stale
Projects
None yet
Development

No branches or pull requests

2 participants