Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for conventional commits on merge_group events to allow rebase merges and manual edits of commit title #1288

Open
dmihalcik-virtru opened this issue Aug 9, 2024 · 0 comments
Assignees
Labels
comp:ci Github Actions Work

Comments

@dmihalcik-virtru
Copy link
Member

The current check for conventional commit messages works with squash merges if they use the the current assigned default behavior of taking in the PR title, but this can be overridden by whoever clicks 'add to merge queue', and doesn't take into account rebase merges.

Instead, if we want to be very strict about it, we should use a commit lint checker that checks all the commits between main (the merge target) and the current temporary branch head

@strantalis strantalis added the comp:ci Github Actions Work label Aug 15, 2024
@github-actions github-actions bot added the Stale label Dec 17, 2024
@jrschumacher jrschumacher self-assigned this Jan 28, 2025
@github-actions github-actions bot removed the Stale label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:ci Github Actions Work
Projects
None yet
Development

No branches or pull requests

3 participants