Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite the config paramters for a step in PPP run #88

Open
project-defiant opened this issue Dec 18, 2024 · 1 comment
Open

Overwrite the config paramters for a step in PPP run #88

project-defiant opened this issue Dec 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@project-defiant
Copy link
Collaborator

Context

The addition of OTAR2081 dataset to the evidence parsers allows us to add a new source of annotation to the variantIndex generation step in gentropy configuration.

This dataset annotations should be only available for the PPP release. This means that we neeed to add a way to overwrite the variant_index step with additional parameters for PPP only run.

@DSuveges @javfg

@project-defiant project-defiant added the enhancement New feature or request label Dec 18, 2024
@javfg
Copy link
Member

javfg commented Dec 18, 2024

There is something like that already:

https://github.com/opentargets/orchestration/blob/dev/src/ot_orchestration/dags/config/unified_pipeline.py#L119

Which adds steps to the DAG conditionally depending on whether the run is standard or PPP.

What we need to do is something similar that allows us to extend the gentropy config with a params_ppp that get appended only if the run is_ppp.

That way you avoid coupling the paramaters of Gentropy steps into the orchestrator config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants