Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: light/dark per site #819

Closed
andersand opened this issue Jan 3, 2020 · 7 comments
Closed

Feature request: light/dark per site #819

andersand opened this issue Jan 3, 2020 · 7 comments

Comments

@andersand
Copy link

Suggestion.

As night coder my eyes are very happy for Stylus, but in the day I prefer to use a light scheme. In Windows 10, I can easily switch between dark and light when I want to, which is excellent usability. What I would want is to be able to set a dark and light theme for my sites in Stylus, then having an option in Stylus that follows windows - as i believe chrome itself does.

I hope this will be considered.

@narcolepticinsomniac
Copy link
Member

Does this PR cover your request? Please test it and provide feedback. I don't care much about such a feature in general, plus I don't use an OS which really supports this feature, so I couldn't really thoroughly test it, even if I wanted to.

I think that up until recently, it was flawed due to a browser bug, but 8 seems to be indicating that he's worked around it. Unfortunately, I see conflicting reports about how well it's working. Anyone who cares about this feature should test the PR and chime in there.

I guess whenever 8 says it's good to go, we can merge it, but more testing is always better. With this particular feature, for whatever reason, feedback always seems minimal to me.

@andersand
Copy link
Author

It seems to be exactly how I would prefer it, also the always on let's people who don't care about this ignore it completely. Yeah will test the branch

@andersand
Copy link
Author

I have tested, the option to "Toggle Light/Dark Mode styles automatica­lly" was found and set to "By system preference", but I did not find anywhere to set "The style should be applied" option for the style. Tried anyway to change between light and dark mode in windows, restarting chrome, but as suspected (since I could not find said option for the style) nothing happened.

@andersand
Copy link
Author

Also in the chrome extensions page there are errors:
image
image

@narcolepticinsomniac
Copy link
Member

Sounds like maybe it still needs some work. Feedback related to that PR will be more useful if posted there.

@nathgit
Copy link

nathgit commented Feb 20, 2020

Suggestion.

As night coder my eyes are very happy for Stylus, but in the day I prefer to use a light scheme. In Windows 10, I can easily switch between dark and light when I want to, which is excellent usability. What I would want is to be able to set a dark and light theme for my sites in Stylus, then having an option in Stylus that follows windows - as i believe chrome itself does.

I hope this will be considered.

I think midnight lizard does this (it only changes colors), but you can't edit the css of theme, like with this.

@tophf
Copy link
Member

tophf commented Oct 3, 2020

Closing in favor of #51.

@tophf tophf closed this as completed Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants