Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy options leaking into request headers #310

Merged

Conversation

kimpepper
Copy link
Collaborator

Description

Legacy options like $params['client']['verbose'] = true; in IndicesNamespace are leaking into the headers that we send with the HTTP request. We should remove them.

Issues Resolved

#301

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.87%. Comparing base (6e63822) to head (e1e9c62).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #310      +/-   ##
============================================
+ Coverage     23.57%   23.87%   +0.29%     
- Complexity     3614     3623       +9     
============================================
  Files           534      538       +4     
  Lines         13797    13856      +59     
============================================
+ Hits           3253     3308      +55     
- Misses        10544    10548       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kimpepper kimpepper force-pushed the fix-legacy-options-in-header branch from e1e9c62 to 346e4bd Compare February 24, 2025 20:19
dblock
dblock previously approved these changes Feb 24, 2025
@kimpepper kimpepper force-pushed the fix-legacy-options-in-header branch from 092f2d9 to 0213d18 Compare February 24, 2025 23:23
@kimpepper kimpepper requested a review from dblock February 24, 2025 23:38
@dblock dblock merged commit 2a85400 into opensearch-project:main Feb 25, 2025
45 checks passed
@kimpepper kimpepper deleted the fix-legacy-options-in-header branch February 25, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants