Fix deprecated class instantiation warnings #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
requested review from
VachaShah,
dblock,
harshavamsi,
shyim and
saimedhi
as code owners
kimpepper
force-pushed
the
fix-deprecation-instantiation-warnings
branch
from
3b92dc5 to
1e822b5
Compare
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
force-pushed
the
fix-deprecation-instantiation-warnings
branch
from
1e822b5 to
d68c725
Compare
Signed-off-by: Kim Pepper <[email protected]>
kimpepper
force-pushed
the
fix-deprecation-instantiation-warnings
branch
from
d11b0c2 to
a723a3a
Compare
kimpepper
changed the title
shyim
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are triggering deprecation warnings in the Client as the deprecated classes are being instantiated. Instead we can just trigger a deprecation warning when the deprecated methods in the Client are called.
This has the benefit of removing some of the phpstan ignored warnings in the baseline.
Issues Resolved
Resolves #283
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.