Serialize boolean query string params as strings (#273)

Signed-off-by: Kim Pepper <[email protected]>

src/OpenSearch/RequestFactory.php

@@ -32,7 +32,7 @@ public function createRequest(
         array $headers = [],
     ): RequestInterface {
         $uri = $this->uriFactory->createUri($uri);
-        $uri = $uri->withQuery(http_build_query($params));
+        $uri = $uri->withQuery($this->createQuery($params));
         $request = $this->psrRequestFactory->createRequest($method, $uri);
         if ($body !== null) {
             $bodyJson = $this->serializer->serialize($body);
@@ -45,4 +45,23 @@ public function createRequest(
         return $request;
     }
 
+    /**
+     * Create a query string from an array of parameters.
+     */
+    private function createQuery(array $params): string
+    {
+        ksort($params);
+
+        return http_build_query(array_map(function ($value) {
+            // Ensure boolean values are serialized as strings.
+            if ($value === true) {
+                return 'true';
+            }
+            if ($value === false) {
+                return 'false';
+            }
+            return $value;
+        }, $params));
+    }
+
 }

tests/RequestFactoryTest.php

@@ -0,0 +1,31 @@
+<?php
+
+declare(strict_types=1);
+
+namespace OpenSearch\Tests;
+
+use GuzzleHttp\Psr7\HttpFactory;
+use OpenSearch\RequestFactory;
+use OpenSearch\Serializers\SerializerInterface;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * Tests the request factory.
+ *
+ * @coversDefaultClass \OpenSearch\RequestFactory
+ */
+class RequestFactoryTest extends TestCase
+{
+    public function testBoolean(): void
+    {
+        $httpFactory = new HttpFactory();
+        $serializer = $this->createMock(SerializerInterface::class);
+
+        $factory = new RequestFactory($httpFactory, $httpFactory, $httpFactory, $serializer);
+
+        $params = ['foo' => true, 'bar' => false];
+        $request = $factory->createRequest('GET', 'http://localhost:9200/_search', $params);
+
+        $this->assertEquals('bar=false&foo=true', $request->getUri()->getQuery());
+    }
+}