From 0dae009a3dc31f7aab323cc14720227961f0bc5d Mon Sep 17 00:00:00 2001 From: Kim Pepper Date: Tue, 4 Feb 2025 07:54:36 +1100 Subject: [PATCH] Remove ksort for request params --- src/OpenSearch/RequestFactory.php | 2 -- tests/RequestFactoryTest.php | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/OpenSearch/RequestFactory.php b/src/OpenSearch/RequestFactory.php index 4c5ff7ac..d08f6bea 100644 --- a/src/OpenSearch/RequestFactory.php +++ b/src/OpenSearch/RequestFactory.php @@ -50,8 +50,6 @@ public function createRequest( */ private function createQuery(array $params): string { - ksort($params); - return http_build_query(array_map(function ($value) { // Ensure boolean values are serialized as strings. if ($value === true) { diff --git a/tests/RequestFactoryTest.php b/tests/RequestFactoryTest.php index e49cbd09..da009964 100644 --- a/tests/RequestFactoryTest.php +++ b/tests/RequestFactoryTest.php @@ -26,6 +26,6 @@ public function testBoolean(): void $params = ['foo' => true, 'bar' => false]; $request = $factory->createRequest('GET', 'http://localhost:9200/_search', $params); - $this->assertEquals('bar=false&foo=true', $request->getUri()->getQuery()); + $this->assertEquals('foo=true&bar=false', $request->getUri()->getQuery()); } }