Remove ksort for request params

opensearch-project · Feb 3, 2025 · 0dae009 · 0dae009
1 parent 289a387
commit 0dae009
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/src/OpenSearch/RequestFactory.php b/src/OpenSearch/RequestFactory.php
@@ -50,8 +50,6 @@ public function createRequest(
      */
     private function createQuery(array $params): string
     {
-        ksort($params);
-
         return http_build_query(array_map(function ($value) {
             // Ensure boolean values are serialized as strings.
             if ($value === true) {

diff --git a/tests/RequestFactoryTest.php b/tests/RequestFactoryTest.php
@@ -26,6 +26,6 @@ public function testBoolean(): void
         $params = ['foo' => true, 'bar' => false];
         $request = $factory->createRequest('GET', 'http://localhost:9200/_search', $params);
 
-        $this->assertEquals('bar=false&foo=true', $request->getUri()->getQuery());
+        $this->assertEquals('foo=true&bar=false', $request->getUri()->getQuery());
     }
 }