[FEATURE] Additional CSI volumes read-write

[jurox83]

Is your feature request related to a problem?

As the current gcs-snapshots plugin does not allow workload identity federation but instead, requires a json file with keys (which is not considered compliant in many regulated environments), an acceptable workaround would be using gcsfuse to mount a gcs storage bucket.
Althought the definition works well via additionalVolumes and annotations, the resulting mount point is set to readOnly! (Even though, the CSI parameter is set to readOnly: false)

What solution would you like?

Propagate the CSI driver parameter for readOnly instead of forcing the value to true.

What alternatives have you considered?

As said, gcs-plugin was considered but also lacks a feature that might be even more effort to implement (unsure about that though)

Do you have any additional context?

opensearch-k8s-operator/opensearch-operator/pkg/reconcilers/util/util.go

Lines 130 to 137 in 2e78967

	if volumeConfig.CSI != nil {
	retVolumes = append(retVolumes, corev1.Volume{
	Name: volumeConfig.Name,
	VolumeSource: corev1.VolumeSource{
	CSI: volumeConfig.CSI,
	},
	})
	}

an initial suggestion from my team would be to adjust the above block to this:

    if volumeConfig.CSI != nil {
        readOnly = volumeConfig.CSI.ReadOnly // Set readOnly based on the CSI configuration
        retVolumes = append(retVolumes, corev1.Volume{
            Name: volumeConfig.Name,
            VolumeSource: corev1.VolumeSource{
                CSI: volumeConfig.CSI,
            },
        })
    }

It would be amazing if this change could make it quickly through the release cycle!!! Meanwhile, we'll try to fork and patch the code for our needs especially to have working snapshots. Thanks for reading <3

[swoehrl-mw]

Hi @jurox83. Since you are already creating a fork, please contribute that change yourself by creating a PR, then we can see about getting that merged.

[jurox83]

Hi @swoehrl-mw, thanks for your response. I tried my best and hopefully did it all correct. If not, please let me know 🙏