From 4f5c346f0ad41cd35b8f715dc2aa71533dccda1a Mon Sep 17 00:00:00 2001 From: Ritvi Bhatt Date: Thu, 20 Feb 2025 16:36:10 -0800 Subject: [PATCH 1/7] update flaky panels tests Signed-off-by: Ritvi Bhatt --- .../plugins/observability-dashboards/4_panels.spec.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js index 6715e3b6a..6e22bfc78 100644 --- a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js +++ b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js @@ -41,6 +41,7 @@ describe('Creating visualizations', () => { }); it('Create first visualization in event analytics', () => { + cy.intercept('POST', '**/_dashboards/api/saved_objects/observability-visualization').as('saveVisualization'); cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[0], { delay: 50, }); @@ -64,8 +65,7 @@ describe('Creating visualizations', () => { cy.get('[data-test-subj="eventExplorer__querySaveConfirm"]') .trigger('mouseover') .click(); - cy.wait(delay); - cy.get('.euiToastHeader__title').contains('successfully').should('exist'); + cy.wait('@saveVisualization').its('response.statusCode').should('eq', 200); }); }); @@ -112,6 +112,8 @@ describe('Testing panels table', () => { }); it('Deletes panels', () => { + cy.get('.euiTableRow').should('exist'); + cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist') cy.get('.euiCheckbox__input[data-test-subj="checkboxSelectAll"]') .trigger('mouseover') .click(); From 44cb31e06da82b7603b077dd6ba8a108ed609cd4 Mon Sep 17 00:00:00 2001 From: Ritvi Bhatt Date: Thu, 20 Feb 2025 16:45:11 -0800 Subject: [PATCH 2/7] update formatting Signed-off-by: Ritvi Bhatt --- .../plugins/observability-dashboards/4_panels.spec.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js index 6e22bfc78..6442b0cce 100644 --- a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js +++ b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js @@ -41,7 +41,11 @@ describe('Creating visualizations', () => { }); it('Create first visualization in event analytics', () => { - cy.intercept('POST', '**/_dashboards/api/saved_objects/observability-visualization').as('saveVisualization'); + cy.intercept( + "POST", + "**/_dashboards/api/saved_objects/observability-visualization", + ).as("saveVisualization"); + cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[0], { delay: 50, }); @@ -113,7 +117,7 @@ describe('Testing panels table', () => { it('Deletes panels', () => { cy.get('.euiTableRow').should('exist'); - cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist') + cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist'); cy.get('.euiCheckbox__input[data-test-subj="checkboxSelectAll"]') .trigger('mouseover') .click(); From d29bdfc316aa55e3840668288eace26ce679f888 Mon Sep 17 00:00:00 2001 From: Ritvi Bhatt Date: Thu, 20 Feb 2025 16:49:08 -0800 Subject: [PATCH 3/7] update formatting Signed-off-by: Ritvi Bhatt --- .../plugins/observability-dashboards/4_panels.spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js index 6442b0cce..4bf042b8e 100644 --- a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js +++ b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js @@ -42,8 +42,8 @@ describe('Creating visualizations', () => { it('Create first visualization in event analytics', () => { cy.intercept( - "POST", - "**/_dashboards/api/saved_objects/observability-visualization", + 'POST', + '**/_dashboards/api/saved_objects/observability-visualization', ).as("saveVisualization"); cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[0], { From 9952e214c8297c855c839e8f3cf8ccb22187970e Mon Sep 17 00:00:00 2001 From: Ritvi Bhatt Date: Thu, 20 Feb 2025 16:53:17 -0800 Subject: [PATCH 4/7] update formatting Signed-off-by: Ritvi Bhatt --- .../plugins/observability-dashboards/4_panels.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js index 4bf042b8e..d91f2af22 100644 --- a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js +++ b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js @@ -44,7 +44,7 @@ describe('Creating visualizations', () => { cy.intercept( 'POST', '**/_dashboards/api/saved_objects/observability-visualization', - ).as("saveVisualization"); + ).as('saveVisualization'); cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[0], { delay: 50, From 56418795a5e590e18d12d2b6c68d731e6371d1b5 Mon Sep 17 00:00:00 2001 From: Ritvi Bhatt Date: Thu, 20 Feb 2025 16:57:12 -0800 Subject: [PATCH 5/7] update formatting Signed-off-by: Ritvi Bhatt --- .../plugins/observability-dashboards/4_panels.spec.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js index d91f2af22..b1963e0e2 100644 --- a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js +++ b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js @@ -43,9 +43,8 @@ describe('Creating visualizations', () => { it('Create first visualization in event analytics', () => { cy.intercept( 'POST', - '**/_dashboards/api/saved_objects/observability-visualization', + '**/_dashboards/api/saved_objects/observability-visualization' ).as('saveVisualization'); - cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[0], { delay: 50, }); From 6934bdbf8331f62fb5902a3b68b90cff9dcb0a9f Mon Sep 17 00:00:00 2001 From: Ritvi Bhatt Date: Thu, 20 Feb 2025 20:57:26 -0800 Subject: [PATCH 6/7] update intercept url Signed-off-by: Ritvi Bhatt --- .../plugins/observability-dashboards/4_panels.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js index b1963e0e2..6602e37ad 100644 --- a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js +++ b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js @@ -43,7 +43,7 @@ describe('Creating visualizations', () => { it('Create first visualization in event analytics', () => { cy.intercept( 'POST', - '**/_dashboards/api/saved_objects/observability-visualization' + '**/api/saved_objects/observability-visualization' ).as('saveVisualization'); cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[0], { delay: 50, From aba51bedd70b7e61904782254d3e1a5ade47855c Mon Sep 17 00:00:00 2001 From: Ritvi Bhatt Date: Thu, 20 Feb 2025 20:58:53 -0800 Subject: [PATCH 7/7] update formatting Signed-off-by: Ritvi Bhatt --- .../plugins/observability-dashboards/4_panels.spec.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js index 6602e37ad..75088879e 100644 --- a/cypress/integration/plugins/observability-dashboards/4_panels.spec.js +++ b/cypress/integration/plugins/observability-dashboards/4_panels.spec.js @@ -41,10 +41,9 @@ describe('Creating visualizations', () => { }); it('Create first visualization in event analytics', () => { - cy.intercept( - 'POST', - '**/api/saved_objects/observability-visualization' - ).as('saveVisualization'); + cy.intercept('POST', '**/api/saved_objects/observability-visualization').as( + 'saveVisualization' + ); cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[0], { delay: 50, });