From 506610780ff6cddf8db8955526ad6aaabc1db690 Mon Sep 17 00:00:00 2001 From: Sumukh Swamy Date: Thu, 20 Feb 2025 20:12:27 -0800 Subject: [PATCH] [BUG]added fix for csv downloads in reports-2.11 (#1724) * added fix for csv downloads in reports-2.11 Signed-off-by: sumukhswamy * updated artifact and url in test Signed-off-by: sumukhswamy --------- Signed-off-by: sumukhswamy --- .github/workflows/release-e2e-workflow-template.yml | 6 +++--- .../plugins/reports-dashboards/04-download.spec.js | 4 +--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release-e2e-workflow-template.yml b/.github/workflows/release-e2e-workflow-template.yml index 33ad16985..6b1d06e55 100644 --- a/.github/workflows/release-e2e-workflow-template.yml +++ b/.github/workflows/release-e2e-workflow-template.yml @@ -115,19 +115,19 @@ jobs: command: ${{ inputs.test-command }} wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: cypress-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos path: cypress-test/cypress/videos # Test reports was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-results diff --git a/cypress/integration/plugins/reports-dashboards/04-download.spec.js b/cypress/integration/plugins/reports-dashboards/04-download.spec.js index f51e7c93f..9251455fd 100644 --- a/cypress/integration/plugins/reports-dashboards/04-download.spec.js +++ b/cypress/integration/plugins/reports-dashboards/04-download.spec.js @@ -91,9 +91,7 @@ describe('Cypress', () => { cy.wait(5000); // open saved search list - cy.get( - 'button.euiButtonEmpty:nth-child(3) > span:nth-child(1) > span:nth-child(1)' - ).click({ force: true }); + cy.get('[data-test-subj="discoverOpenButton"]').click({ force: true }); cy.wait(5000); // click first entry