Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Throttle monitor dry run made by UI #1212

Open
AWSHurneyt opened this issue Feb 20, 2025 · 0 comments
Open

[BUG] Throttle monitor dry run made by UI #1212

AWSHurneyt opened this issue Feb 20, 2025 · 0 comments
Labels
bug Something isn't working untriaged

Comments

@AWSHurneyt
Copy link
Collaborator

AWSHurneyt commented Feb 20, 2025

What is the bug?
The alerting UI uses this onRunQuery (code link) function to call the ExecuteMonitor API (documentation link) which performs dry runs of a monitor as it's being configured. The response from the dry run is then used to enrich the UI with preview data.

However, there is currently no throttling in place to limit the number of times the dry runs execute. This means that a dry run could be executed for every character entered into a UI form field.

Implementation of the ExecuteMonitor API limits could involve:

  1. Throttling number of times the a dry run can be performed in a period of time
  2. Only performing a dry run when blurring/clicking out of a UI form input field

Workarounds

  1. Dry runs are only executed automatically when using the "visual editor" monitor definition method. Use the "extraction query editor" monitor definition method to avoid unintended, repeated dry runs as it requires the user to manually trigger a dry run by clicking the "Run" button.
    1. TODO: Will need to ensure throttling is in place for the "Run" button as well.
    2. TODO: Will need to consider whether the "Extraction query response" box can properly display a response preview for per document monitors, or if it should be removed from the UI. Due to the nature of per document monitors, the "Trigger condition response" may be the only meaningful preview option for this monitor type.
@AWSHurneyt AWSHurneyt added bug Something isn't working untriaged labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

1 participant