Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay for zoomable image on front page to prevent scroll interruption #158

Open
TMUND opened this issue Oct 5, 2016 · 7 comments
Open

Comments

@TMUND
Copy link
Contributor

TMUND commented Oct 5, 2016

Hello :)

I've come to realize that every time I go to the main page, as I start to scroll down I almost invariably end up zooming the Duomo image accidentally. It's a minor thing but some sort of overlay could help facilitate that scroll flow a little better; what do you think?

@avandecreme
Copy link
Member

Hello!
Could you explain how that would work?

@TMUND
Copy link
Contributor Author

TMUND commented Oct 6, 2016

Sure, I was imagining a slightly opaque overlay with a message that says something along the lines of "click to reveal/play with demo". That way those who are familiar with OSD could just keep scrolling over the demo and the first time users would have an easy way to activate it.

Does that make sense?

@avandecreme
Copy link
Member

Ha got it. I am neither in favor or against such a thing. Let's wait for @iangilman thoughts :)

@TMUND
Copy link
Contributor Author

TMUND commented Oct 6, 2016

As I said, it's a fairly minor thing but every time I visit the page I have a little D'oh moment when I zoom in accidentally while scrolling :)

@iangilman
Copy link
Member

Hello! Excellent point. This is a usability issue other sites have with OSD as well, depending on their page structure. I figure this is an opportunity for us to come up with some sort of best practice.

Given that, I'm not excited about the "click to begin zooming" solution, since I don't want that to become the new standard.

Here's another thought: how about if we try to add some intelligence to the wheel handling, where if the user has scrolled the page and hasn't moved their mouse, but now the mouse is on top of the OSD viewer, any wheel action is allowed to go through to continue scrolling the page? I don't know... could be too weird (i.e. produce unexpected results).

Anyway, I'd love to see us play with various solutions to this issue.

@TMUND
Copy link
Contributor Author

TMUND commented Oct 11, 2016

@iangilman could you point me to where this code would live? I can experiment with your suggestion when I get some free time :)

@iangilman
Copy link
Member

Sounds great! The code for that image is right here:

https://github.com/openseadragon/site-build/blob/master/www/index.html#L16-L23

...I figure you can just expand on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants