Non-Crossref DOI Settings are available in manager to edit but seem to do nothing

[hachacha]

Under all settings where you are able to change DOI-related things: DOI display prefix, suffix, DOI Pattern, Use Crossref DOIs all seem to do nothing other than retain the value that is entered and saved. In identifiers/logic.py all the settings that are being referenced are specific to crossref and these are being ignored or not used.

Confusing at this point but perhaps you want to reintroduce them when #871 is completed?

[ajrbyers]

I’m not sure I follow you. identifiers/logic.py clearly uses settings from the Crossref page to determine the registration of Crossref identifiers.

For example under create_crossref_doi_identifier I can see:

doi_prefix = setting_handler.get_setting('Identifiers', 'crossref_prefix', article.journal)

Which is fetching the Crossref prefix for the journal....

[hachacha]

Sorry the title of this issue was a bit unclear.
There are settings that make changes, yes, the crossref-specific settings variables are being used but not the other ones that appear to reference a non-specific DOI registrar:
doi_display_prefix
doi_pattern
and
doi_display_suffix are not referenced other than in the json defaults.

the use_crossref is being used but it's only being used to bounce out any requests to use something other than crossref.

if not use_crossref:
        logging.info("[DOI] Not using Crossref DOIs on this journal. Aborting registration.")
        return

[ajrbyers]

Right, I see what you're saying.

doi_pattern is used in identifiers.logic and the other two are not used as you say but we probably will use them when we re-write the Identifiers app to support other DOI registrars.