Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rummage Portal field has wrong field type #4607

Open
joemull opened this issue Jan 31, 2025 · 0 comments · May be fixed by #4608
Open

Rummage Portal field has wrong field type #4607

joemull opened this issue Jan 31, 2025 · 0 comments · May be fixed by #4608
Assignees
Labels
bug Something's not working priority-urgent size XS Extra small

Comments

@joemull
Copy link
Member

joemull commented Jan 31, 2025

Problem

When I want to filter supporters by country, the filter is not applied.

This is because the widget provides multiple choices, but the form field is a single choice field:

self.fields[facet_key] = forms.ChoiceField(
widget=forms.widgets.CheckboxSelectMultiple,
choices=choices,
required=False,
)

As a result the data is misaligned when the form is validated.

Proposed solution

Use MultipleChoiceField.

@joemull joemull added the bug Something's not working label Jan 31, 2025
@joemull joemull self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's not working priority-urgent size XS Extra small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant