Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort topnav items by sequence #1049

Closed
hachacha opened this issue Mar 26, 2019 · 2 comments
Closed

Sort topnav items by sequence #1049

hachacha opened this issue Mar 26, 2019 · 2 comments
Labels
new feature A new thing that doesn't exist yet

Comments

@hachacha
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The navigation items are not being sorted when entering sequence.

Describe the solution you'd like
When returning the navigation items from context_processor put .order(sequence) on the filter that is returning these items.
image

Additional context
https://github.com/BirkbeckCTP/janeway/blob/master/src/core/context_processors.py#L74
I tried on my local adding .order_by('sequence') and it worked on my local. I can make a PR for this unless this may break something else or if it's not the correct way of going about this. Related: Is there any way to change the order of non-cms pages among these cms pages other than directly editing the template?

@hachacha hachacha added the new feature A new thing that doesn't exist yet label Mar 26, 2019
@ajrbyers
Copy link
Member

ajrbyers commented Mar 26, 2019

@hachacha we are rebuilding the navigation and cms systems in 1.4:

#509

So you can have a completely custom nav mixing CMS items and what were previously fixed items as well as all previous fixed pages becoming customisable pages with elements in them,

Happy for you to put a PR in for this as its part of 509 but can you tag it as 509 and close this?

@hachacha
Copy link
Contributor Author

hachacha commented Mar 26, 2019

sure thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new thing that doesn't exist yet
Projects
None yet
Development

No branches or pull requests

2 participants