Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout error if clone hangs waiting for https password on taf repo clone #534

Open
n-dusan opened this issue Sep 20, 2024 · 1 comment
Labels

Comments

@n-dusan
Copy link
Contributor

n-dusan commented Sep 20, 2024

Updater sometimes hangs when running taf repo clone https:/github.com/** instead of taf repo clone [email protected]://**

It should instead timeout error when it's taking too long to resolve https url. Ibe possible to capture output and poll if git clone subprocess is taking too long.

@renatav renatav changed the title Add timeout error if updater hangs waiting for https password on taf repo clone Add timeout error if clone hangs waiting for https password on taf repo clone Dec 4, 2024
@renatav renatav added the good first issue Good for newcomers label Dec 4, 2024
@renatav renatav moved this from Backlog to Todo in TAF Planning Dec 4, 2024
@renatav renatav removed the good first issue Good for newcomers label Jan 15, 2025
@renatav
Copy link
Collaborator

renatav commented Jan 15, 2025

I am removing the good first issue label from this. The problem is that this will need to work even in combination with parallel update of dependencies. I just recently tried implementing a timeout in combination with a thread pool and gave up after a few unsuccessful attempts. This might require some refactoring. Should be easy enough when cloning the root repository, which would catch this particular error, so if that's the only goal, it's definitely doable. But a more generic implementation might be challenging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants