Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: sourmash v4: a multitool to quickly search, compare, and analyze genomic and metagenomic data sets #6783

Closed
editorialbot opened this issue May 25, 2024 · 33 comments
Assignees
Labels
C pre-review pyOpenSci Submissions associated with pyOpenSci Python Rust Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 25, 2024

Submitting author: @bluegenes (N. Tessa Pierce-Ward)
Repository: https://github.com/sourmash-bio/sourmash
Branch with paper.md (empty if default branch):
Version: v4.8.8
Editor: @Kevin-Mattheus-Moerman
Reviewers: @Kevin-Mattheus-Moerman
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/11313337f8dcd9183cf24d4624062971"><img src="https://joss.theoj.org/papers/11313337f8dcd9183cf24d4624062971/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/11313337f8dcd9183cf24d4624062971/status.svg)](https://joss.theoj.org/papers/11313337f8dcd9183cf24d4624062971)

Author instructions

Thanks for submitting your paper to JOSS @bluegenes. Currently, there isn't a JOSS editor assigned to your paper.

@bluegenes if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels May 25, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1101/029827 is OK
- 10.21105/joss.00027 is OK
- 10.12688/f1000research.19675.1 is OK
- 10.1101/2022.01.11.475838 is OK
- 10.1101/2022.11.02.514947 is OK
- 10.1016/j.amc.2019.02.018 is OK
- 10.1101/gr.277651.123 is OK
- 10.1101/2023.11.06.565843 is OK
- 10.1186/s12859-022-05103-0 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.94 s (491.0 files/s, 198730.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Standard ML                     97              0              0          57302
Python                         151          16321           7734          55735
SVG                              1              5              0          12420
Rust                            49           2294            858          11536
Markdown                        50           2606              0           7994
CSV                             56             11              0           5733
YAML                            15            123             20            775
TOML                             6             45              8            379
C/C++ Header                     1            163             46            275
Jupyter Notebook                 5              0           3572            271
make                             2             49              6            242
INI                              1             20              0            224
HTML                             1             45              3            146
Nix                              3             30             10            130
TeX                              1              8              0             88
JSON                            19              1              0             50
reStructuredText                 1              6              0             28
Rmd                              1             16             23             17
CSS                              1              2              0              8
Bourne Shell                     2              0              0              6
-------------------------------------------------------------------------------
SUM:                           463          21745          12280         153359
-------------------------------------------------------------------------------

Commit count by author:

   994	C. Titus Brown
   299	dependabot[bot]
   251	Luiz Irber
    65	Tessa Pierce Ward
    28	Laurent Gautier
    22	Keya Barve
    12	Tim Head
    10	Mohamed Abuelanin
     8	Olga Botvinnik
     7	Erik Young
     7	Taylor Reiter
     5	Pranathi Vemuri
     4	Connor Tiffany
     4	Tessa Pierce
     4	dependabot-preview[bot]
     3	Hannah Eve Houts
     3	S. Joshua Swamidass
     3	brooksph
     2	Camille Scott
     2	Daniel Standage
     2	David Koslicki
     2	Harriet Alexander
     2	Jason Stajich
     2	Peter Cock
     2	Titus Brown
     2	ccbaumler
     1	Abhishek Anant
     1	Andreas Sjödin
     1	Arfon Smith
     1	Brad Nelson
     1	Colton Baumler
     1	Connor T. Skennerton
     1	Daniel Dsouza
     1	Fabian Klötzl
     1	Francesco Beghini
     1	Ivan Ogasawara
     1	Katrin Leinweber
     1	Marisa Lim
     1	NapsterInBlue
     1	Phillip Brooks
     1	Ria Lodh
     1	Ricky Lim
     1	jgardner78
     1	ljcohen
     1	pyup.io bot

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 821

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @majensen as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@majensen
Copy link
Member

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @majensen is now the editor

@majensen
Copy link
Member

@amoeba are you open to reviewing this work? Thanks for considering - @majensen

@majensen
Copy link
Member

Hi @bede - would you be willing to review this work for JOSS? Thanks for your consideration -- @majensen

@bede
Copy link

bede commented May 31, 2024 via email

@majensen
Copy link
Member

@editorialbot add @bede as reviewer

@editorialbot
Copy link
Collaborator Author

@bede added to the reviewers list!

@amoeba
Copy link

amoeba commented Jun 3, 2024

Hi @majensen: Yes I can review this and within the next two weeks.

@majensen
Copy link
Member

majensen commented Jun 3, 2024

That is awesome @amoeba - thank you

@majensen
Copy link
Member

majensen commented Jun 3, 2024

@editorialbot add @amoeba as reviewer

@editorialbot
Copy link
Collaborator Author

@amoeba added to the reviewers list!

@majensen
Copy link
Member

majensen commented Jun 3, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6830.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot remove @majensen as editor

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @Kevin-Mattheus-Moerman is now the editor

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot add me as reviewer

@editorialbot
Copy link
Collaborator Author

@Kevin-Mattheus-Moerman added to the reviewers list!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot remove @bede as reviewer

@editorialbot
Copy link
Collaborator Author

@bede removed from the reviewers list!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot remove @amoeba as reviewer

@editorialbot
Copy link
Collaborator Author

@amoeba removed from the reviewers list!

@Kevin-Mattheus-Moerman
Copy link
Member

Apologies @bede @amoeba @majensen because this has been reviewed already here: pyOpenSci/software-submission#129 we follow a different procedure. Thanks anyway for being willing to help!

@Kevin-Mattheus-Moerman
Copy link
Member

This was reviewed here; pyOpenSci/software-submission#129

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman added the pyOpenSci Submissions associated with pyOpenSci label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C pre-review pyOpenSci Submissions associated with pyOpenSci Python Rust Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

5 participants