Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: flowerMD: Flexible Library of Organic Workflows and Extensible Recipes for Molecular Dynamics #5960

Closed
editorialbot opened this issue Oct 19, 2023 · 33 comments
Assignees
Labels
Jupyter Notebook pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 19, 2023

Submitting author: @marjanalbouye (Marjan Albooyeh)
Repository: https://github.com/cmelab/flowerMD
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @lucydot
Reviewers: @csadorf, @LIVazquezS, @abhishektiwari
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/75c5135b3e0eb1b561a89783ce949067"><img src="https://joss.theoj.org/papers/75c5135b3e0eb1b561a89783ce949067/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/75c5135b3e0eb1b561a89783ce949067/status.svg)](https://joss.theoj.org/papers/75c5135b3e0eb1b561a89783ce949067)

Author instructions

Thanks for submitting your paper to JOSS @marjanalbouye. Currently, there isn't a JOSS editor assigned to your paper.

@marjanalbouye if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Oct 19, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.11 s (714.7 files/s, 195639.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                              7              1             29          11175
Python                          41            858           1228           4767
TeX                              1             15              0            247
Jupyter Notebook                 4              0           2362            229
YAML                             8             16             14            194
Markdown                         2             34              2            163
reStructuredText                13             71            104             56
DOS Batch                        1              8              1             26
make                             1              4              7              9
INI                              1              0              0              4
-------------------------------------------------------------------------------
SUM:                            79           1007           3747          16870
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1188

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41524-022-00906-4 is OK
- 10.1080/00268976.2020.1742938 is OK
- 10.21105/joss.01831 is OK
- 10.1063/1.2978177 is OK
- 10.1021/ct0502864 is OK
- 10.1038/s41467-021-27627-4 is OK
- 10.1021/acs.jcim.3c00081 is OK
- 10.1007/978-981-10-1128-3_5 is OK
- 10.1016/j.cpc.2021.108171 is OK
- 10.5281/zenodo.8370982 is OK
- 10.1088/1361-651X/ab6a44 is OK
- 10.1126/sciadv.abg9763 is OK
- 10.1063/1.470016 is OK
- 10.3390/polym13132162 is OK

MISSING DOIs

- 10.1016/j.commatsci.2019.109363 may be a valid DOI for title: HOOMD-blue: A Python package for high-performance molecular dynamics and hard particle Monte Carlo simulations
- 10.1021/acs.macromol.8b00011 may be a valid DOI for title: pyPRISM: a computational tool for liquid-state theory calculations of macromolecular materials

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

HOOMD-TF: GPU-Accelerated, Online Machine Learning in the HOOMD-blue Molecular Dynamics Engine
Submitting author: @RainierBarrett
Handling editor: @richardjgowers (Active)
Reviewers: @malramsay64, @rmeli
Similarity score: 0.8359

pyrexMD: Workflow-Orientated Python Package for Replica Exchange Molecular Dynamics
Submitting author: @ArtVoro
Handling editor: @jgostick (Active)
Reviewers: @janash, @rosecers, @jarvist
Similarity score: 0.8335

BioSimSpace: An interoperable Python framework for biomolecular simulation
Submitting author: @lohedges
Handling editor: @will-rowe (Retired)
Reviewers: @amritagos, @richardjgowers
Similarity score: 0.8249

FHI-vibes: Ab Initio Vibrational Simulations
Submitting author: @flokno
Handling editor: @jgostick (Active)
Reviewers: @keipertk, @ajjackson
Similarity score: 0.8167

flowTorch - a Python library for analysis and reduced-order modeling of fluid flows
Submitting author: @AndreWeiner
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @akaptano, @JaroslavHron, @salrm8, @hkjeldsberg
Similarity score: 0.8142

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Oct 19, 2023

@marjanAlbouye thanks for this submission. I am the EiC for this track and here to help with initial steps. I will start looking for a handling editor. For the moment can you try work on the following:

  • Can you please try to address the above ☝️ potentially missing DOI's
  • In your affiliations, can you please spell out USA as United States of America
  • Please add clear contributing guidelines to your repository. We recommend adding a CONTRIBUTING.md file and to link to it in your readme. Here is a useful site showing examples of such a file: https://contributing.md/example/

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @lucydot as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Kevin-Mattheus-Moerman
Copy link
Member

@lucydot do you think you can help edit this work? I think @danielskatz has offered to review so that is a nice start.

@danielskatz
Copy link

Sorry @Kevin-Mattheus-Moerman - I did not mean to volunteer to review. This is not in my expertise at that level.

@marjanalbooyeh
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41524-022-00906-4 is OK
- 10.1080/00268976.2020.1742938 is OK
- 10.21105/joss.01831 is OK
- 10.1063/1.2978177 is OK
- 10.1021/ct0502864 is OK
- 10.1016/j.commatsci.2019.109363 is OK
- 10.1038/s41467-021-27627-4 is OK
- 10.1021/acs.jcim.3c00081 is OK
- 10.1021/acs.macromol.8b00011 is OK
- 10.1007/978-981-10-1128-3_5 is OK
- 10.1016/j.cpc.2021.108171 is OK
- 10.5281/zenodo.8370982 is OK
- 10.1088/1361-651X/ab6a44 is OK
- 10.1126/sciadv.abg9763 is OK
- 10.1063/1.470016 is OK
- 10.3390/polym13132162 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@marjanalbooyeh
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

HOOMD-TF: GPU-Accelerated, Online Machine Learning in the HOOMD-blue Molecular Dynamics Engine
Submitting author: @RainierBarrett
Handling editor: @richardjgowers (Active)
Reviewers: @malramsay64, @rmeli
Similarity score: 0.8371

pyrexMD: Workflow-Orientated Python Package for Replica Exchange Molecular Dynamics
Submitting author: @ArtVoro
Handling editor: @jgostick (Active)
Reviewers: @janash, @rosecers, @jarvist
Similarity score: 0.8320

BioSimSpace: An interoperable Python framework for biomolecular simulation
Submitting author: @lohedges
Handling editor: @will-rowe (Retired)
Reviewers: @amritagos, @richardjgowers
Similarity score: 0.8213

FHI-vibes: Ab Initio Vibrational Simulations
Submitting author: @flokno
Handling editor: @jgostick (Active)
Reviewers: @keipertk, @ajjackson
Similarity score: 0.8145

flowTorch - a Python library for analysis and reduced-order modeling of fluid flows
Submitting author: @AndreWeiner
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @akaptano, @JaroslavHron, @salrm8, @hkjeldsberg
Similarity score: 0.8114

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@marjanalbooyeh
Copy link

@Kevin-Mattheus-Moerman Thank you. I addressed the comments in your last message.

Here is the list of our suggested reviewers:

  • LIVazquezS
  • srmnitc
  • csadorf
  • ptmerz
  • rosecers

@lucydot
Copy link

lucydot commented Oct 23, 2023

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @lucydot is now the editor

@lucydot
Copy link

lucydot commented Oct 23, 2023

Hi @LIVazquezS @csadorf @rosecers - are you available to review this submission to JOSS? It is molecular dynamics + Python + reproducible workflows, which appears in-line with some of your interests...

@LIVazquezS
Copy link

Hi @lucydot , Yes, I am available to review this work.

@csadorf
Copy link

csadorf commented Oct 23, 2023

@lucydot Yes, I can review this.

@rosecers
Copy link

@lucydot as it might be a COI to have @csadorf and I both reviewing, I'll opt out of this review. Let me know if you end up needing another round.

@abhishektiwari
Copy link

@lucydot I will be open to review this submission. Have worked with scientific workflow systems.

@lucydot
Copy link

lucydot commented Oct 26, 2023

Thanks @rosecers for your update, we now have three reviewers so your expertise won't be needed (for this one!).

Thanks @csadorf @LIVazquezS @abhishektiwari - I'll add you now as reviewers, and then ask our editorialbot to start a new thread for the review itself. There will be instructions generated at the top of the new thread. If you have any questions about the process please do contact me, the best place to do that will be over in that new thread.

@openjournals openjournals deleted a comment from editorialbot Oct 26, 2023
@openjournals openjournals deleted a comment from editorialbot Oct 26, 2023
@lucydot
Copy link

lucydot commented Oct 26, 2023

@editorialbot add @csadorf as reviewer

@editorialbot
Copy link
Collaborator Author

@csadorf added to the reviewers list!

@lucydot
Copy link

lucydot commented Oct 26, 2023

@editorialbot add @LIVazquezS as reviewer

@editorialbot
Copy link
Collaborator Author

@LIVazquezS added to the reviewers list!

@lucydot
Copy link

lucydot commented Oct 26, 2023

@editorialbot add @abhishektiwari as reviewer

@editorialbot
Copy link
Collaborator Author

@abhishektiwari added to the reviewers list!

@lucydot
Copy link

lucydot commented Oct 26, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jupyter Notebook pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

9 participants