Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Peacock.jl: Photonic crystals in Julia #2239

Closed
whedon opened this issue May 23, 2020 · 62 comments
Closed

[PRE REVIEW]: Peacock.jl: Photonic crystals in Julia #2239

whedon opened this issue May 23, 2020 · 62 comments

Comments

@whedon
Copy link

whedon commented May 23, 2020

Submitting author: @sp94 (Samuel John Palmer)
Repository: https://github.com/sp94/Peacock.jl
Version: v0.1.0
Editor: @dpsanders
Reviewers: mlxd, @nmoran
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @sp94. Currently, there isn't an JOSS editor assigned to your paper.

@sp94 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 23, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 23, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.03 s (468.1 files/s, 51135.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           11            168             55            923
Markdown                         2             70              0            215
TOML                             2             39              1            147
TeX                              1              5              0            125
-------------------------------------------------------------------------------
SUM:                            16            282             56           1410
-------------------------------------------------------------------------------


Statistical information for the repository '2239' was gathered on 2020/05/23.
No commited files with the specified extensions were found.

@whedon
Copy link
Author

whedon commented May 23, 2020

Reference check summary:

OK DOIs

- None

MISSING DOIs

- https://doi.org/10.1073/pnas.2133313100 may be missing for title: Coloration strategies in peacock feathers
- https://doi.org/10.1007/978-1-4615-1963-8_41 may be missing for title: Inhibited spontaneous emission in solid-state physics and electronics
- https://doi.org/10.1103/physrevlett.58.2486 may be missing for title: Strong localization of photons in certain disordered dielectric superlattices
- https://doi.org/10.1007/3-540-27701-3_14 may be missing for title: Photonic crystal fibres
- https://doi.org/10.1126/science.1133734 may be missing for title: Quantum spin Hall effect and topological phase transition in HgTe quantum wells
- https://doi.org/10.1103/physrevlett.114.223901 may be missing for title: Scheme for achieving a topological photonic crystal by using dielectric material
- https://doi.org/10.1103/physrevresearch.1.032005 may be missing for title: Engineering fragile topology in photonic crystals: Topological quantum chemistry of light
- https://doi.org/10.1002/qute.201900117 may be missing for title: Tutorial: computing topological invariants in 2D photonic crystals

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented May 23, 2020

@arfon
Copy link
Member

arfon commented May 23, 2020

👋 @sp94 - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS earlier in the week we've had > 50 papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 23, 2020
@sp94
Copy link

sp94 commented May 24, 2020

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 24, 2020

@sp94
Copy link

sp94 commented May 24, 2020

Thanks for adding me to the waiting list!

From the list of possible reviewers, here are some in Physics/optics/solid state/condensed matter theory, and who also lists Julia in their programming languages:

  • crstnbr
  • mdavezac
  • frssp
  • solanpaa

@kyleniemeyer
Copy link

Hi @jgostick, can you take on this submission as your first editorial assignment?

@kyleniemeyer
Copy link

@whedon invite @jgostick as editor

@whedon
Copy link
Author

whedon commented Jun 6, 2020

@jgostick has been invited to edit this submission.

@jgostick
Copy link

jgostick commented Jun 6, 2020

@kyleniemeyer Does it matter that I don't know what a photonic crystal is, have not yet started to use Julia, and can't think of single person who could review this?

@kyleniemeyer
Copy link

@jgostick I can find one that's a bit closer to your areas of expertise for your first one.

@dpsanders do you have the bandwidth to edit this submission?

@kyleniemeyer
Copy link

@whedon invite @dpsanders as editor

@whedon
Copy link
Author

whedon commented Jun 6, 2020

@dpsanders has been invited to edit this submission.

@dpsanders
Copy link

👋 @kyleniemeyer Yes, but the process will be slow for the next couple of weeks.

@kyleniemeyer
Copy link

@dpsanders totally understand, I'm in the same situation (hence your invitation coming over the weekend rather than at the beginning of the week...)

@kyleniemeyer

This comment has been minimized.

@whedon

This comment has been minimized.

@kyleniemeyer kyleniemeyer removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jun 7, 2020
@kyleniemeyer
Copy link

whoops! sorry @jgostick, that was a mistake.

@kyleniemeyer
Copy link

@whedon assign @dpsanders as editor

@whedon whedon assigned dpsanders and unassigned jgostick Jun 7, 2020
@whedon
Copy link
Author

whedon commented Jun 7, 2020

OK, the editor is @dpsanders

@dpsanders
Copy link

👋 @sp94: Sorry for the delay. Everything is looking good to me, thanks!

I'll start looking for reviewers.

@dpsanders
Copy link

Sorry for the delay here.

👋 Hi @crstnbr, @mdavezac and @mlxd: Would you be willing to review this submission to JOSS?

@mlxd
Copy link

mlxd commented Sep 15, 2020

Hi @dpsanders I'm happy to review this work.

@mdavezac
Copy link

@dpsanders, I'm happy to give it go.

@sp94
Copy link

sp94 commented Sep 15, 2020

Thanks for offering your time, everyone

@dpsanders I just noticed that @mdavezac and I are both at Imperial College London, so there could be a perceived conflict of interest. I don't think we've ever met or interacted before so hopefully this can be waived?

@dpsanders
Copy link

Ah sorry for missing that. Let me consult

@kyleniemeyer
Copy link

@dpsanders @sp94 Thanks for being upfront about that institutional connection—I think this is fine, though, since you have not actually worked together.

@danielskatz
Copy link

Let me disagree - this is clearly a conflict, and we can waive it, but if there's another option where we don't have to, it would be better - that should be our first choice.

@mdavezac
Copy link

As @sp94 said, I don't think we've interacted in any way either. If needed, I am still open to reviewing this paper.

@dpsanders
Copy link

Thanks @mdavezac and apologies for the situation.

👋 @Datseris and @nmoran: Would you be able to review this submission to JOSS?

@Datseris
Copy link

Datseris commented Sep 16, 2020

Hi @dpsanders , thanks for letting me know. If you had asked one year in the past, I would be happy to review this. But unfortunately at this point in time I neither work in condensed matter anymore, but I am also in a period of preparing several papers in parallel and lack the bandwidth to review this properly :(

@nmoran
Copy link

nmoran commented Sep 16, 2020

Hi @dpsanders, I'm happy to take a look at reviewing this work. It would be my first review for JOSS so wondering if there are some reviewing guidelines or example reviews I could look at?

@kyleniemeyer
Copy link

@nmoran just jumping in here: we do have explicit review criteria, and in fact when the actual review begins (in a new GitHub issue), you will have a checklist to work through.

Thanks for your willingness to review this submission!

@dpsanders
Copy link

Thanks @nmoran! And thanks @kyleniemeyer for the pointer.

If you browse through recent papers published by JOSS, each of them links to the open review, so you can get an idea of how they are carried out.

@dpsanders
Copy link

@whedon add mlxd as reviewer

@whedon whedon assigned dpsanders and mlxd and unassigned dpsanders Sep 16, 2020
@whedon
Copy link
Author

whedon commented Sep 16, 2020

OK, mlxd is now a reviewer

@dpsanders
Copy link

@whedon add @nmoran as reviewer

@whedon whedon assigned dpsanders, mlxd and nmoran and unassigned dpsanders and mlxd Sep 16, 2020
@dpsanders
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 16, 2020

OK, @nmoran is now a reviewer

@whedon
Copy link
Author

whedon commented Sep 16, 2020

OK, I've started the review over in #2678.

@whedon whedon closed this as completed Sep 16, 2020
@nmoran
Copy link

nmoran commented Sep 16, 2020

Thanks @dpsanders and @kyleniemeyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests