-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Peacock.jl: Photonic crystals in Julia #2239
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
👋 @sp94 - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor. Since reopening JOSS earlier in the week we've had > 50 papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months. Thanks in advance for your patience! |
@whedon generate pdf |
Thanks for adding me to the waiting list! From the list of possible reviewers, here are some in Physics/optics/solid state/condensed matter theory, and who also lists Julia in their programming languages:
|
Hi @jgostick, can you take on this submission as your first editorial assignment? |
@jgostick has been invited to edit this submission. |
@kyleniemeyer Does it matter that I don't know what a photonic crystal is, have not yet started to use Julia, and can't think of single person who could review this? |
@jgostick I can find one that's a bit closer to your areas of expertise for your first one. @dpsanders do you have the bandwidth to edit this submission? |
@whedon invite @dpsanders as editor |
@dpsanders has been invited to edit this submission. |
👋 @kyleniemeyer Yes, but the process will be slow for the next couple of weeks. |
@dpsanders totally understand, I'm in the same situation (hence your invitation coming over the weekend rather than at the beginning of the week...) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
whoops! sorry @jgostick, that was a mistake. |
@whedon assign @dpsanders as editor |
OK, the editor is @dpsanders |
👋 @sp94: Sorry for the delay. Everything is looking good to me, thanks! I'll start looking for reviewers. |
Hi @dpsanders I'm happy to review this work. |
@dpsanders, I'm happy to give it go. |
Thanks for offering your time, everyone @dpsanders I just noticed that @mdavezac and I are both at Imperial College London, so there could be a perceived conflict of interest. I don't think we've ever met or interacted before so hopefully this can be waived? |
Ah sorry for missing that. Let me consult |
@dpsanders @sp94 Thanks for being upfront about that institutional connection—I think this is fine, though, since you have not actually worked together. |
Let me disagree - this is clearly a conflict, and we can waive it, but if there's another option where we don't have to, it would be better - that should be our first choice. |
As @sp94 said, I don't think we've interacted in any way either. If needed, I am still open to reviewing this paper. |
Hi @dpsanders , thanks for letting me know. If you had asked one year in the past, I would be happy to review this. But unfortunately at this point in time I neither work in condensed matter anymore, but I am also in a period of preparing several papers in parallel and lack the bandwidth to review this properly :( |
Hi @dpsanders, I'm happy to take a look at reviewing this work. It would be my first review for JOSS so wondering if there are some reviewing guidelines or example reviews I could look at? |
@nmoran just jumping in here: we do have explicit review criteria, and in fact when the actual review begins (in a new GitHub issue), you will have a checklist to work through. Thanks for your willingness to review this submission! |
Thanks @nmoran! And thanks @kyleniemeyer for the pointer. If you browse through recent papers published by JOSS, each of them links to the open review, so you can get an idea of how they are carried out. |
@whedon add mlxd as reviewer |
OK, mlxd is now a reviewer |
@whedon start review |
OK, @nmoran is now a reviewer |
OK, I've started the review over in #2678. |
Thanks @dpsanders and @kyleniemeyer |
Submitting author: @sp94 (Samuel John Palmer)
Repository: https://github.com/sp94/Peacock.jl
Version: v0.1.0
Editor: @dpsanders
Reviewers: mlxd, @nmoran
Managing EiC: Arfon Smith
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Author instructions
Thanks for submitting your paper to JOSS @sp94. Currently, there isn't an JOSS editor assigned to your paper.
@sp94 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: