Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝(project) add a ralph lrs tutorial #540

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Conversation

wilbrdt
Copy link
Contributor

@wilbrdt wilbrdt commented Dec 11, 2023

Purpose

New users should be able to run Ralph LRS easily, while being able to grasp Ralph features and configurations.

Proposal

Adding an LRS tutorial à la FastAPI to run Ralph LRS from scratch.

Note, if you want to review the final result:
make docs-serve

@wilbrdt wilbrdt added this to the 4.0 milestone Dec 11, 2023
@wilbrdt wilbrdt self-assigned this Dec 11, 2023
Copy link
Contributor

@quitterie-lcs quitterie-lcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnificient job! A few remarks to improve reader experience

@wilbrdt wilbrdt force-pushed the add-doc-lrs-tutorial branch from c5f9ac0 to 958dad5 Compare December 13, 2023 10:38
Copy link
Contributor

@Leobouloc Leobouloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Little note not to forget the "TODO"

@wilbrdt wilbrdt marked this pull request as ready for review December 14, 2023 13:23
@wilbrdt wilbrdt force-pushed the add-doc-lrs-tutorial branch from dac02ee to 57f66f6 Compare December 14, 2023 14:23
@wilbrdt wilbrdt added needs review and removed WIP labels Dec 18, 2023
Copy link
Collaborator

@SergioSim SergioSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work! 🥇

image

Only minor questions/suggestions)

I think more links in the tutorial pointing to Ralph's documentation would be helpful to let readers dig deeper into some topics (beyond the example).

@wilbrdt wilbrdt force-pushed the add-doc-lrs-tutorial branch from 57f66f6 to 8b4fea7 Compare December 19, 2023 15:03
@wilbrdt wilbrdt requested a review from SergioSim December 19, 2023 15:03
@wilbrdt wilbrdt force-pushed the add-doc-lrs-tutorial branch 3 times, most recently from 3ebe964 to 8685444 Compare December 20, 2023 13:21
Copy link
Collaborator

@SergioSim SergioSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Awesome! 👍

Only some final minor questions/suggestions)

image

@wilbrdt wilbrdt force-pushed the add-doc-lrs-tutorial branch from 8685444 to 0faa5d1 Compare December 28, 2023 11:37
New user should be able to run Ralph LRS easily, while being able to grasp the
Ralph features.
Adding an LRS tutorial à la FastAPI to run Ralph LRS from scratch.
We heavily use `lrs.json.gz` JSON file from Potsie for our documentation.
Adding it to the project, and changing `@timestamp` into `timestamp` for all
statements in it.
@wilbrdt wilbrdt force-pushed the add-doc-lrs-tutorial branch from 0faa5d1 to dfca593 Compare December 29, 2023 10:09
CSS file for neoteroi OpenAPI plugin was not correctly retrieved by mkdocs,
and was not used.
Fixing it.
Flarelytics client was referenced in the main theme, but is inexistent and not
used.
Removing it.
@wilbrdt wilbrdt merged commit be6c509 into master Dec 29, 2023
@wilbrdt wilbrdt deleted the add-doc-lrs-tutorial branch December 29, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants