-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm chart #227
Add helm chart #227
Conversation
To make a long story short: to be able to point to a service that has a fixed name (e.g. without blue-green suffix).
Our way to distinguish stacks (previous/current/next) in a blue-green deployment strategy. Our playbooks use this selector.
Prefix for ingresses?
We want to use the most relevant/recommended community tools. What do you suggest? |
Do you want to keep this strategy? you can still have one service, (one for each blue and green version) and add two host in the ingress for the last working (static) version with a hostname without the suffix blue/green
I assume you want to preserve this mechanism? so I need to implement this label on the chart
Yes, I saw it on ingress and services I assume now that the value will be either blue or green?
The convention is to start with one |
No we don't want to keep Arnold-related strategy in this new standard implementation. From what we understand, flux/flagger can handle the blue-green deployment strategy without having to manage this as we did. As a consequence, only one version of each service is required: the static-one.
Nope.
This is a URL prefix, e.g.
Duly noted. ArgoCD is in the scope, but for now you don't have to handle this complexity in the current implementation. |
f4086c4
to
798ce65
Compare
@jmaupetit Can you please make a full review of this PR? I made the final clean up. |
44a300f
to
d6eb141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I'll test it by the end of the day and give you more feedback.
I fixed some issues, but I still have one related to the |
2ea773b
to
e365bd9
Compare
- name: RALPH_BACKENDS__DATABASE__ES__CLIENT_OPTIONS__ca_certs | ||
value: "/usr/local/share/ca-certificates/es-cluster.pem" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned yesterday, this can be improved thanks to a ConfigMap
(looping over a values.yml
file configuration) injected in the environment.
05f724c
to
32c2a4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution @waammar!
32c2a4c
to
d5e4e88
Compare
We already deploy Ralph on Kubernetes using Arnold and a dedicated tray, but we need to provide more standard options for our users. This Chart is still experimental. Expect things to change in a near future.
d5e4e88
to
d894278
Compare
Purpose
Add Helm chart for Ralph
Description
Created the chart under
src/helm
I tried to migrate the logic from the.j2
tray files.The
version
label was replaced as the helm convention forapp.kubernetes.io/version
The checksum from the secret name was deleted. The annotation
checksum/config:
was used instead on the secret, the checksum is automatically generated fromvault.yaml
it help to update the secret object every time a value is updated.Note that the
.Chart.AppVersion
is better used to track the version deployed and it should reflect theimage.tag
There is only one vars files
values.yaml
the vault is under specific filevault.yaml
used only for generating the secrets.Questions
static
deployment_stamp
?prefix
?ToDo
You can use
helm template .
under./src/helm/ralph
to check the output of the chart, it will show you the final manifest that will be deployed.