Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent field is not valid openId IFI #467

Closed
1 of 2 tasks
Leobouloc opened this issue Oct 17, 2023 · 1 comment · Fixed by #473
Closed
1 of 2 tasks

Agent field is not valid openId IFI #467

Leobouloc opened this issue Oct 17, 2023 · 1 comment · Fixed by #473
Assignees
@Leobouloc
Labels
bug
Milestone
5.0

Comments

@Leobouloc
Copy link
Contributor

Leobouloc commented Oct 17, 2023 •
edited
Loading

Bug Report

Expected behavior/code
agent field created by ralph with openId does not have a valid openid field:

ralph/src/ralph/api/auth/oidc.py

Line 147 in 95c6ede

agent={"openid": id_token.sub},

Environment

  • Ralph version:3.9

Possible Solution

  • Revert to the code originally proposed by @wilbrdt : agent={"openid": f"{id_token.iss}/{id_token.sub}"}
  • Add test for validity of the created agent
@wilbrdt wilbrdt added this to the 4.0 milestone Oct 19, 2023
@wilbrdt wilbrdt linked a pull request Oct 19, 2023 that will close this issue
(api) Add option to enforce use of scopes (all/read, all/write, etc.) #463
Merged
4 tasks
@wilbrdt wilbrdt added the bug label Oct 19, 2023
@Leobouloc
Copy link
Contributor Author

Should be fixed by #473

@wilbrdt wilbrdt linked a pull request Oct 19, 2023 that will close this issue
✨ (api) Allow multiple authentication methods (oidc & basic) #473
Merged
2 tasks
@wilbrdt wilbrdt removed a link to a pull request Oct 19, 2023
(api) Add option to enforce use of scopes (all/read, all/write, etc.) #463
Merged
4 tasks
@wilbrdt wilbrdt modified the milestones: 4.0, 5.0 Oct 27, 2023
@github-project-automation github-project-automation bot moved this from Todo to Closed in Ralph roadmap Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leobouloc Leobouloc

Labels
bug
Projects
Ralph roadmap
Status: Closed
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

✨ (api) Allow multiple authentication methods (oidc & basic) openfun/ralph
2 participants
@Leobouloc @wilbrdt