Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(emails) improve emails with MJML and Jinja templates #14

Merged
merged 1 commit into from
Aug 22, 2024
Merged

✨(emails) improve emails with MJML and Jinja templates #14

merged 1 commit into from
Aug 22, 2024

Conversation

wilbrdt
Copy link
Contributor

@wilbrdt wilbrdt commented Aug 9, 2024 •
edited
Loading

Purpose

  • Introducing MJML, a responsive email framework, to reduce the pain of writing responsive emails.
  • Render email template files with Jinja
  • Restructure the project layout, having now an additional non-Python app for building mails

@wilbrdt wilbrdt self-assigned this Aug 9, 2024
@wilbrdt wilbrdt force-pushed the add-emailing-subtask branch 2 times, most recently from 0fc2892 to 866d637 Compare August 12, 2024 09:37
@wilbrdt wilbrdt force-pushed the add-emailing-subtask branch 2 times, most recently from 2cc0f25 to 54bd4ab Compare August 12, 2024 14:52
@wilbrdt wilbrdt force-pushed the add-emailing-subtask branch from 54bd4ab to c03011b Compare August 13, 2024 08:31
@wilbrdt wilbrdt added the WIP label Aug 13, 2024
@wilbrdt wilbrdt force-pushed the add-emailing-subtask branch from c03011b to dfed050 Compare August 13, 2024 10:51
@wilbrdt wilbrdt force-pushed the add-emailing-subtask branch from dfed050 to 1e41ef6 Compare August 13, 2024 12:27
@wilbrdt wilbrdt added needs review and removed WIP labels Aug 13, 2024
@wilbrdt wilbrdt requested a review from quitterie-lcs August 13, 2024 15:04
@wilbrdt wilbrdt marked this pull request as ready for review August 13, 2024 15:05
@wilbrdt wilbrdt force-pushed the improve-emailing branch 2 times, most recently from de3ef75 to 9bbed79 Compare August 14, 2024 09:00
@wilbrdt wilbrdt force-pushed the add-emailing-subtask branch from 1e41ef6 to 8012b5b Compare August 14, 2024 13:03
@wilbrdt wilbrdt force-pushed the add-emailing-subtask branch from 8012b5b to 7c81c4c Compare August 14, 2024 13:06
@wilbrdt wilbrdt force-pushed the improve-emailing branch 5 times, most recently from 1a992d4 to 588f3f9 Compare August 16, 2024 13:32
Base automatically changed from add-emailing-subtask to main August 16, 2024 13:32
@wilbrdt wilbrdt force-pushed the improve-emailing branch 2 times, most recently from 6aa048a to 16b6b87 Compare August 16, 2024 13:40
jbpenrath
jbpenrath reviewed Aug 19, 2024
View reviewed changes
jbpenrath
jbpenrath approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@jbpenrath jbpenrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few comments then LGTM ✅

@wilbrdt
✨(emails) use mjml to generate html and text emails
3073e76 
Introducing MJML, a responsive email framework, to reduce the pain of writing
responsive emails.
@wilbrdt wilbrdt merged commit 7af178e into main Aug 22, 2024
9 of 10 checks passed
@wilbrdt wilbrdt deleted the improve-emailing branch August 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbpenrath jbpenrath jbpenrath approved these changes

@jonathanreveille jonathanreveille jonathanreveille approved these changes

@quitterie-lcs quitterie-lcs quitterie-lcs approved these changes

Assignees

@wilbrdt wilbrdt

Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wilbrdt @jbpenrath @jonathanreveille @quitterie-lcs