From 70796ddaa5742f7aedb5b1c6b8f1555b4d3caaca Mon Sep 17 00:00:00 2001 From: Wilfried BARADAT Date: Thu, 5 Dec 2024 14:43:04 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=87(sentry)=20active=20recursive=20scr?= =?UTF-8?q?ubbing=20of=20events?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some PII are still sent to Sentry, under extra.celery-job.args or kwargs. The Sentry SDK event scrubber does not scrub recursively by default. Activating recursive scrubbing to avoid sending emails and usernames to Sentry. --- CHANGELOG.md | 1 + src/app/mork/celery/celery_app.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b4bd55d..0201cbd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ and this project adheres to ### Changed - Disable Brevo request on empty Brevo API URL setting +- Activate recursive scrubbing of Sentry events ### Fixed diff --git a/src/app/mork/celery/celery_app.py b/src/app/mork/celery/celery_app.py index a268015..0a14b1f 100644 --- a/src/app/mork/celery/celery_app.py +++ b/src/app/mork/celery/celery_app.py @@ -50,7 +50,7 @@ def init_sentry(**_kwargs): environment=settings.SENTRY_EXECUTION_ENVIRONMENT, max_breadcrumbs=50, send_default_pii=False, - event_scrubber=EventScrubber(pii_denylist=pii_denylist), + event_scrubber=EventScrubber(pii_denylist=pii_denylist, recursive=True), before_send=before_send, ) sentry_sdk.set_tag("application", "celery")