diff --git a/CHANGELOG.md b/CHANGELOG.md index 68c5531a7a..9080080e7f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,9 @@ right (and close / open it) - rename LiveRegistration model in LiveSession - Disable jitsi prejoin page - Admin can access all LiveSession belonging to a video +- Move on-stage request functional (in Instructor view) from under +the video to the ViewersList in the right panel + ### Fixed diff --git a/src/frontend/components/Button/ButtonLayout/index.spec.tsx b/src/frontend/components/Button/ButtonLayout/index.spec.tsx index 8a48b60a26..326add545c 100644 --- a/src/frontend/components/Button/ButtonLayout/index.spec.tsx +++ b/src/frontend/components/Button/ButtonLayout/index.spec.tsx @@ -4,7 +4,7 @@ import { render, screen } from '@testing-library/react'; import { ButtonLayout } from '.'; const Icon = jest.fn(() => icon); -const Badge = () => badge; +const badge = 'badge'; describe('', () => { afterEach(() => { @@ -29,7 +29,7 @@ describe('', () => { it('does not render the badge if there is no Icon set', () => { render( } + badge={badge} label="Button" reversedColor={'reversed-color'} tintColor={'int-color'} @@ -61,7 +61,7 @@ describe('', () => { it('renders the icon and the badge and the title', () => { render( } + badge={badge} Icon={() => icon} label="Button" reversedColor={'reversed-color'} @@ -78,7 +78,7 @@ describe('', () => { it('renders the Button component with default style', () => { render( } + badge={badge} Icon={Icon} label="Button" reversedColor={'#ffffff'} @@ -96,7 +96,7 @@ describe('', () => { { height: '100%', iconColor: '#0a67de', - focusColor: 'none', + focusColor: undefined, }, {}, ); @@ -107,7 +107,7 @@ describe('', () => { it('renders the Button component with reversed style', () => { render( } + badge={badge} Icon={Icon} label="Button" reversed diff --git a/src/frontend/components/Button/ButtonLayout/index.tsx b/src/frontend/components/Button/ButtonLayout/index.tsx index d07c4a01c4..795b6c6137 100644 --- a/src/frontend/components/Button/ButtonLayout/index.tsx +++ b/src/frontend/components/Button/ButtonLayout/index.tsx @@ -22,7 +22,6 @@ const IconBox = styled(Box)` const TextBox = styled(Box)` display: flex; - margin-top: 6px; text-align: center; `; @@ -34,11 +33,14 @@ const StyledText = styled(Text)` screenSize === 'small' ? '-0.3px' : '-0.13px'}; line-height: ${({ screenSize }: ResponsiveProps) => screenSize === 'small' ? '0.8rem' : '0.9rem'}; - margin: auto; +`; + +const StyledTextBadge = styled(Text)` + font-family: 'Roboto-Bold'; `; export interface ButtonLayoutSubComponentProps { - badge?: JSX.Element; + badge?: string; Icon?: React.FC; label?: string; } @@ -61,29 +63,37 @@ export const ButtonLayout = ({ }: ButtonLayoutProps) => { const size = useContext(ResponsiveContext); - let iconColor; - let rectColor; - - if (!reversed) { - iconColor = tintColor; - rectColor = 'none'; - } else { - iconColor = reversedColor; - rectColor = tintColor; - } + const iconColor = reversed ? reversedColor : tintColor; + const rectColor = reversed ? tintColor : undefined; return ( - + {Icon && ( - {badge} + {badge && ( + + + {badge} + + + )} )} {label && ( - - + + {label} diff --git a/src/frontend/components/Button/index.spec.tsx b/src/frontend/components/Button/index.spec.tsx index aa5d96e932..1159b71773 100644 --- a/src/frontend/components/Button/index.spec.tsx +++ b/src/frontend/components/Button/index.spec.tsx @@ -4,7 +4,7 @@ import React from 'react'; import { Button } from '.'; const Icon = jest.fn(() => icon); -const Badge = () => badge; +const badge = 'badge'; describe('