Manage 'on stage' request directly in viewers list #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
from
378d83a to
4fa9376
Compare
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
6 times, most recently
from
891d2b2 to
9bf3eba
Compare
kernicPanel
reviewed
Mar 25, 2022
src/frontend/utils/conversejs/converse-plugins/participantsTrackingPlugin.ts
Outdated
Show resolved
Hide resolved
src/frontend/components/ViewersList/InstructorViewersList/index.tsx
Outdated
Show resolved
Hide resolved
lunika
reviewed
Mar 28, 2022
src/frontend/components/ViewersList/InstructorViewersList/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/ViewersList/InstructorViewersList/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/ViewersList/InstructorViewersList/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/ViewersList/components/ViewersListTextButton/index.spec.tsx
Outdated
Show resolved
Hide resolved
The hand icon allowing to leave the discussion is still present, I didn't notice it 👍 |
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
from
6516558 to
108ab95
Compare
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
from
4c02954 to
13147ed
Compare
RVassili
reviewed
Mar 30, 2022
src/frontend/components/Chat/SharedChatComponents/ChatAvatar/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/Chat/SharedChatComponents/ChatAvatar/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/Chat/SharedChatComponents/ChatAvatar/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/ViewersList/StudentViewersList/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/ViewersList/StudentViewersList/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/ViewersList/StudentViewersList/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/ViewersList/InstructorViewersList/index.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/ViewersList/InstructorViewersList/index.tsx
Outdated
Show resolved
Hide resolved
lunika
reviewed
Mar 30, 2022
kernicPanel
approved these changes
Mar 30, 2022
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
from
e3935e7 to
0512ff4
Compare
RVassili
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
2 times, most recently
from
980d5ba to
96b7cd6
Compare
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
3 times, most recently
from
f6ac6a9 to
5162c0b
Compare
RVassili
reviewed
Apr 5, 2022
| const AvatarBox = styled(Box)` | ||
| // 2 last digits correspond to the alhpa of the hexcolor, in hexadecimal | ||
| background-color: ${normalizeColor('blue-active', theme)}19; |
There was a problem hiding this comment.
why are you not using the Box's property 'background' ?
| // minWidth is set otherwise avatar width is crushed by the margin of the component next to the avatar | ||
| min-width: 24px; | ||
| min-width: 26px; |
| @@ -0,0 +1,179 @@ | |||
| import React, { useMemo } from 'react'; | |||
| @@ -0,0 +1,102 @@ | |||
| import React, { useMemo } from 'react'; | |||
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
from
2ca348a to
6baeb04
Compare
RVassili
approved these changes
Apr 5, 2022
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
4 times, most recently
from
512f2fa to
4086278
Compare
kernicPanel
approved these changes
Apr 6, 2022
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
2 times, most recently
from
c94a16d to
51c1bb6
Compare
Add the jid in ParticipantType and update the participantTrackingPlugin in order to record this information jointly to the name of the user.
Avatar was a little too small (a 24px square instead of a 26px one) and color was not exactly the same as on the mockup.
This badge indicates how many students are actually requesting to go on stage.
Add a new component ViewersList, which is in charge of displaying the viewers list, and the on stage management buttons, depending on if the user is an instructor or not. This commit also add all necessaries components needed for ViewersList to work properly.
The StudentViewersList is not used anymore and the ViewersList replaces it. The Viewers component makes some little changes to the UI of the viewers list and add 'on-stage request' management features directly into the list.
The 'on-stage request' mangement system has been moved into the viewers list, so the old components displayed under the video are not needed anymore.
roro-lv
force-pushed
the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
from
51c1bb6 to
1617e34
Compare
roro-lv
deleted the
feature/roro-lv/manage-on-stage-request-in-viewers-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
For now, 'on stage' requests appear under the video on the instructor view. The goal of this PR is to keep this functionnal, but to put it directly in the viewers list instead. The desired result is shown below :
🚩 The 'invite' function is not implemented here, see #1438