🔥(backend) remove field owner and is_main on CreditCard model

Since the latest developments where we use `owners` many-to-many
relation instead of `owner` and `is_main` on CreditCardOwnership
model instead of the CreditCard model, it was time to completely
remove those fields from the CreditCard model.

Fix #1057

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to
 
 ### Changed
 
+- Remove `owner` and `is_main` in CreditCard model permanently
 - Remove `is_active` on order group client serializer
 
 ## [2.16.0] - 2025-02-13

src/backend/joanie/payment/apps.py

@@ -13,7 +13,6 @@ class PaymentConfig(AppConfig):
     # pylint: disable=import-outside-toplevel, unused-import
     def ready(self):
         """Import credit card post delete receiver."""
-        import joanie.payment.checks
         from joanie.payment.models import (  # ,
             credit_card_post_delete_receiver,
         )

src/backend/joanie/payment/migrations/0011_remove_creditcard_is_main_remove_creditcard_owner.py

@@ -0,0 +1,21 @@
+# Generated by Django 4.2.18 on 2025-02-18 08:55
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('payment', '0010_creditcardownership_and_more'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='creditcard',
+            name='is_main',
+        ),
+        migrations.RemoveField(
+            model_name='creditcard',
+            name='owner',
+        ),
+    ]

src/backend/joanie/payment/models.py

@@ -485,23 +485,13 @@ class CreditCard(BaseModel):
     )
     expiration_year = models.PositiveSmallIntegerField(_("expiration year"))
     last_numbers = models.CharField(_("last 4 numbers"), max_length=4)
-    # Deprecated
-    owner = models.ForeignKey(
-        to=User,
-        verbose_name=_("owner"),
-        related_name="credit_cards",
-        on_delete=models.CASCADE,
-        blank=True,
-        null=True,
-    )
     owners = models.ManyToManyField(
         to=User,
         verbose_name=_("owners"),
         related_name="payment_cards",
         through="CreditCardOwnership",
         through_fields=("credit_card", "owner"),
     )
-    is_main = models.BooleanField(_("main"), default=False)  # Deprecated
     payment_provider = models.CharField(
         _("payment provider"), max_length=50, null=True, blank=True
     )

src/backend/joanie/tests/payment/test_backend_base.py

@@ -293,7 +293,7 @@ def test_payment_backend_base_do_on_payment_success(self):
 
         # - Credit card has been deleted
         self.assertIsNone(order.credit_card)
-        self.assertEqual(owner.credit_cards.count(), 0)
+        self.assertEqual(owner.payment_cards.count(), 0)
         with self.assertRaises(CreditCard.DoesNotExist):
             CreditCard.objects.get(id=credit_card.id)
             credit_card.refresh_from_db()

src/backend/joanie/tests/payment/test_models_credit_card.py

@@ -2,7 +2,7 @@
 
 from unittest import mock
 
-from django.core.exceptions import ValidationError
+from django.core.exceptions import FieldError, ValidationError
 
 from joanie.core import enums
 from joanie.core.factories import OrderFactory, UserFactory
@@ -263,3 +263,29 @@ def test_models_credit_card_delete_unused(self):
         self.assertFalse(
             CreditCard.objects.filter(orders__state__in=no_card_order_states).exists()
         )
+
+    def test_models_credit_card_owner_field_is_removed(self):
+        """
+        The `owner` field of the CreditCard is removed, it should raise an error if
+        when we want to set a User.
+        """
+        with self.assertRaises(FieldError) as context:
+            CreditCardFactory(owner=UserFactory())
+
+        self.assertEqual(
+            str(context.exception),
+            "Invalid field name(s) for model CreditCard: 'owner'.",
+        )
+
+    def test_models_credit_card_is_main_field_is_removed(self):
+        """
+        The `is_main` field of the CreditCard is removed, it should raise an error if
+        when we want to set a boolean value.
+        """
+        with self.assertRaises(FieldError) as context:
+            CreditCardFactory(is_main=True)
+
+        self.assertEqual(
+            str(context.exception),
+            "Invalid field name(s) for model CreditCard: 'is_main'.",
+        )