-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(react) add async mode to Select #305
Open
daproclaima
wants to merge
27
commits into
main
Choose a base branch
from
feat/async-options-for-select
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
457d922
✨(react) introduce mono async searchable select
daproclaima cd38f69
⚡️(react) prevent unecessary async options fetching
daproclaima c795bd5
✅(react) update test for select with async options fetching
daproclaima c876a16
✨(react) add use of loader in mono searchable select
daproclaima 8c576ba
✅(react) add test for searchable mono select
daproclaima bb2c096
💬(react) add select loader translations
daproclaima f573509
🔧(vitest) add workspace configuration
daproclaima 5d9dee9
♻️(react) improve select mono searchable
daproclaima 7d25e30
♻️(react) gather options fetching code in mono select
daproclaima 6be1825
✅(react) test controlled Select mono searchable with fetched options
daproclaima 193b0fe
📝(react) add story for Select mono
daproclaima 104b794
📝(react) update documentation of mono select
daproclaima 0dfb7b7
💄(react) move loader for select mono searchable
daproclaima 19a0ca0
🐛(react) fix options fetching in select mono searchable
daproclaima ab25244
🐛(react) fix options reset for select mono searchable
daproclaima 1965f80
🐛(react) fix select mono searchable menu toggle
daproclaima 6f212af
⏪️(react) revert select mono searchable menu toggle change
daproclaima f883441
⏪️(react) cancel options reset for select mono searchable
daproclaima 8051ba5
🐛(react) fix options reset for select mono searchable
daproclaima 0fd628f
📝(react) update stories for mono select
daproclaima f744390
🐛(react) select mono searchable work with loading state
daproclaima 00d50dd
🚸(react) change select mono arrow button
daproclaima 6fd14cb
✨(react) add options fetching to controllable select mono searchable
daproclaima 0f780aa
🐛(react) update mono select options fetching
daproclaima 3a1607b
📝(react) update stories for mono select
daproclaima ab61478
🎨(react) improve select mono-common code
daproclaima 13e89dc
🚨(react) fix select mono stories
daproclaima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,7 @@ dist | |
*.njsproj | ||
*.sln | ||
*.sw? | ||
*.tool-versions | ||
|
||
vite.config.ts.timestamp-* | ||
env.d | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
# @openfun/cunningham-react | ||
|
||
## 2.10.0 | ||
|
||
### Minor Changes | ||
|
||
- 0b45f51: add async option fetching mode to select mono | ||
|
||
## 2.9.4 | ||
|
||
### Patch Changes | ||
|
@@ -425,6 +431,8 @@ | |
- 4ebbf16: Add component's tokens handling | ||
|
||
[unreleased]: https://github.com/openfun/cunningham/compare/@openfun/[email protected] | ||
[2.10.0]: https://github.com/openfun/cunningham/compare/@openfun/[email protected]...@openfun/[email protected] | ||
[2.9.4]: https://github.com/openfun/cunningham/compare/@openfun/[email protected]...@openfun/[email protected] | ||
[2.9.3]: https://github.com/openfun/cunningham/compare/@openfun/[email protected]...@openfun/[email protected] | ||
[2.9.2]: https://github.com/openfun/cunningham/compare/@openfun/[email protected]...@openfun/[email protected] | ||
[2.9.1]: https://github.com/openfun/cunningham/compare/@openfun/[email protected]...@openfun/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should reword the commit eaf2953488a16d1cfa9722c071786afb53f345f2
Actually, the gitmoji used mention work in progress