Autoremove/update item from the cart if stock changed during checkout #13121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move sufficient_stock? to Orders::CheckStockService
Update line item if any related variant has run out of stock or has had stock reduced
It replicates the modal used by the cart : app/assets/javascripts/templates/out_of_stock.html.haml
We now check for insufficient stock when loading the checkout details or before updating the order.
There is no easy way to share template between AngularJS and Rails. The modal in `edit.html.haml` is a copy of app/assets/javascripts/templates/out_of_stock.html.haml, so we need to update both if either of them is updated.
mkllnk
requested changes
Feb 5, 2025
| end | ||
|
|
||
| def sufficient_stock? | ||
| @sufficient_stock ||= order.insufficient_stock_lines.blank? |
There was a problem hiding this comment.
This kind of caching doesn't work with boolean values. If the result is false then it gets re-computed on every call. I think that you need to check for nil.
There was a problem hiding this comment.
I see that it was just copy and paste and broken before.
| = t("js.out_of_stock.now_out_of_stock") | ||
| - if variant.on_hand > 0 | ||
| %span | ||
| = t("js.out_of_stock.only_n_remainging", num: variant.on_hand) |
There was a problem hiding this comment.
Typo? Oh no, the typo is in the translation files!
I would either add a comment # sic! here, rename it or maybe start new lazy translations so that we can delete the old ones when we get rid of AngularJS.
| @@ -152,6 +156,7 @@ def order_params | |||
| # state. We need to do this when moving back to a previous checkout step, the update action takes | |||
| # care of moving the order state forward. | |||
| def update_order_state | |||
| # debugger | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
When on the check out pages, update the order when an item becomes out of stock or an item stock is below the ordered quantity.
What should we test?
As guest or a logged in customer
--> you should see a modal telling you :
Repeat the above scenario when trying to :
You should be redirected to the "Details" step, and you should see an out of stock modal.
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.