Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider un-exporting EpochTime.IsSet #15

Closed
sbinet opened this issue Feb 12, 2018 · 1 comment · Fixed by #21
Closed

consider un-exporting EpochTime.IsSet #15

sbinet opened this issue Feb 12, 2018 · 1 comment · Fixed by #21
Assignees
@Areontar

Comments

@sbinet
Copy link
Contributor

sbinet commented Feb 12, 2018

it's only used internally for marshaling.

we shouldn't export it.
@Areontar Areontar self-assigned this Dec 16, 2019
@Areontar
Copy link
Contributor

Agreed, will make mods

sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Dec 16, 2019
@sbinet
all: unexport EpochTime.isSet
9711a77 
Fixes openfoodfacts#15.
@sbinet sbinet mentioned this issue Dec 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Areontar Areontar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

all: unexport EpochTime.isSet sbinet-alt63/openfoodfacts-go
2 participants
@sbinet @Areontar