Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go idoms #10

Closed
sbinet opened this issue Feb 12, 2018 · 1 comment
Closed

Go idoms #10

sbinet opened this issue Feb 12, 2018 · 1 comment
Assignees
@Areontar

Comments

@sbinet
Copy link
Contributor

sbinet commented Feb 12, 2018 •
edited
Loading

hi there,

I discovered OpenFoodFacts last week (via "Le Canard enchaîné") and learned it was a GSoC organization today :)
(and, obviously, had an API for my favorite language. yay!)

I have skimmed quickly the package and have a few suggestions about the API, to make it more Go-idiomatic:

  • rename HttpApi into Client
  • rename NewHttpApiOperator into NewClient
  • drop the DataProvider interface and make NewClient return a concrete *Client
  • error values are usually named ErrSomething and error types MyTypeError:
    • rename ProductRetrievalError into ErrNoProduct
    • rename AnonymousUserError into ErrUnauthorized
  • rename UrlString into URL
@teolemon
Copy link
Member

teolemon commented Feb 12, 2018 •
edited
Loading

Go for it ;-)

sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Feb 12, 2018
@sbinet
all: rename HttpApi into Client
1681b37 
This CL renames HttpApi into a more Go-idiomatic Client.

Updates openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Feb 12, 2018
@sbinet
all: drop DataProvider interface
53ffbee 
This CL drops the unneeded DataProvider interface and renames exported
error variables into more Go-idiomatic variables.

Updates openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Feb 12, 2018
@sbinet
all: rename UrlString into URL
ba87919 
Fixes openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Feb 12, 2018
@sbinet
all: rename UrlString into URL
1992500 
Updates openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Feb 12, 2018
@sbinet
all: rename Client.GetProduct into Product
c377c4d 
Fixes openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Feb 12, 2018
@sbinet
all: rename HttpApi into Client
c1cfb5b 
This CL renames HttpApi into a more Go-idiomatic Client.

Updates openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Feb 12, 2018
@sbinet
all: drop DataProvider interface
c5889f7 
This CL drops the unneeded DataProvider interface and renames exported
error variables into more Go-idiomatic variables.

Updates openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Feb 12, 2018
@sbinet
all: rename UrlString into URL
088a581 
Updates openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Feb 12, 2018
@sbinet
all: rename Client.GetProduct into Product
902331f 
Fixes openfoodfacts#10.
@Areontar Areontar self-assigned this Dec 16, 2019
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Dec 16, 2019
@sbinet
all: rename HttpApi into Client
1bf839f 
This CL renames HttpApi into a more Go-idiomatic Client.

Updates openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Dec 16, 2019
@sbinet
all: drop DataProvider interface
94e3513 
This CL drops the unneeded DataProvider interface and renames exported
error variables into more Go-idiomatic variables.

Updates openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Dec 16, 2019
@sbinet
all: rename UrlString into URL
6c1a49d 
Updates openfoodfacts#10.
sbinet added a commit to sbinet-alt63/openfoodfacts-go that referenced this issue Dec 16, 2019
@sbinet
all: rename Client.GetProduct into Product
2b2e4e8 
Fixes openfoodfacts#10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Areontar Areontar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbinet @teolemon @Areontar