Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make replacements a keyword argument to prompt! #289

Open
WilliamMcCumstie opened this issue Sep 9, 2019 · 0 comments
Open

Make replacements a keyword argument to prompt! #289

WilliamMcCumstie opened this issue Sep 9, 2019 · 0 comments

Comments

@WilliamMcCumstie
Copy link
Contributor

The replacements argument to the prompt! method updates the model with the new values. This occur before the method prompts for any missing keys within its template.

It should not however be a positional argument as it's inconsistent with the other class methods. Instead, replacements should be a keyword argument.

The method needs refactoring in general, possible to behave more like flight-metal version. However it current works in general.

def self.prompt!(replacements=nil, *a, all: false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant