Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete in reverse order #239

Open
ColonelPanics opened this issue Jul 1, 2019 · 2 comments
Open

Delete in reverse order #239

ColonelPanics opened this issue Jul 1, 2019 · 2 comments
Assignees

Comments

@ColonelPanics
Copy link
Member

When a group is deployed it is deployed in alphabetical order of the nodes. When deleting it should do the reverse of deploy (to cope with any potential issues of dependent resources).

@WilliamMcCumstie
Copy link
Contributor

WilliamMcCumstie commented Jul 15, 2019

Deleting the deployments links into the dependency management stuff. Possible a good idea to look at it first: #238

Similarly to the creation issue, the linking between "Deployments" needs to be handled correctly. For a first pass, only simple management is required. A more advanced issue will be opened with graph theory.

This time dependents instance method needs to be added to the Domain and Nodes. The Domain#dependents should return all the nodes. And Nodes#dependents should return an empty array.

Then when deleting a Node or Domain, then all the dependents need to be deleted first.

EDIT: Ignore this, see below

@WilliamMcCumstie
Copy link
Contributor

As the issue initially states, the nodes should be deleted in reverse alphabetical order. But also, all the running deployments should be checked to see if they rely on the nodes being deleted. If they do, then an error should be raised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants