Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback from github.com/openfga/language/pull/422 #423

Merged
merged 2 commits into from
Feb 24, 2025
Merged

feedback from github.com/openfga/language/pull/422 #423

merged 2 commits into from
Feb 24, 2025

Conversation

yissellokta
Copy link
Contributor

feedback from github.com//pull/422

Description

  • Added more assertions to the condition tests
  • AddEdge to accept slice of conditions
  • Added more comments to better understand the algorithm changes.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@yissellokta yissellokta requested a review from a team as a code owner February 21, 2025 22:23
adriantam
adriantam previously approved these changes Feb 21, 2025
View reviewed changes
@yissellokta yissellokta added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit c97ce59 Feb 24, 2025
10 checks passed
@yissellokta yissellokta deleted the feat/graph-cleanup branch February 24, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriantam adriantam adriantam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yissellokta @adriantam