Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: OEP 63 - TOC Resolution Request #484

Merged
merged 17 commits into from
Apr 30, 2024
Merged

docs: OEP 63 - TOC Resolution Request #484

merged 17 commits into from
Apr 30, 2024

Conversation

antoviaque
Copy link
Contributor

The TOC discussed during the April 2023 meeting a series of guidelines for operating and taking decisions. This includes establishing a way for the community to use the TOC to help take decisions, which this OEP implements.

@antoviaque antoviaque requested a review from e0d May 18, 2023 13:31
@antoviaque antoviaque self-assigned this May 18, 2023
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 18, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented May 18, 2023

Thanks for the pull request, @antoviaque! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@antoviaque
Copy link
Contributor Author

@e0d This is a first draft, would you like to do a pass of review?

@e0d
Copy link
Contributor

e0d commented May 18, 2023

I will take a detailed pass through tomorrow. Thanks for pulling this together.

@nedbat
Copy link
Contributor

nedbat commented May 19, 2023

It's great to clarify how the TOC can be involved with the community and vice-versa. One suggestion for this OEP: at least in US courts, an appeal is what happens if you don't like a decision that has been made, and you kick it up to a higher authority. That was my first thought when I saw "TOC Appeal."

Using some of your other words in this draft, maybe we could call it "Request for TOC Decision" ?

@e0d
Copy link
Contributor

e0d commented May 19, 2023

It's great to clarify how the TOC can be involved with the community and vice-versa. One suggestion for this OEP: at least in US courts, an appeal is what happens if you don't like a decision that has been made, and you kick it up to a higher authority. That was my first thought when I saw "TOC Appeal."

Using some of your other words in this draft, maybe we could call it "Request for TOC Decision" ?

I agree with this, I'd even soften it more, "Request of TOC input."

@itsjeyd
Copy link

itsjeyd commented May 23, 2023

label: core contributor

@github-actions github-actions bot added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label May 23, 2023
@antoviaque
Copy link
Contributor Author

@nedbat @e0d Good point about the fact that, for a decision to be appealed, it needs to have been taken already :)

For a better name, "TOC Decision" would work for me. "TOC Input" seem weak - if people want to ask for only "input", they can already do that via the forum for example, or asking TOC members directly. Since we are trying to establish a formal decision process for the TOC based on community input/issues, the name should convey that notion imho. At the same time, since the TOC can also refuse to take the decision (or can have a hard time taking decisions too :) ), I understand the hesitation. So I've looked into alternatives words, and "TOC Arbitration" could be a good one - it conveys the authority and decision-making power of the TOC on the topics submitted, while giving plenty of room to give any type of response the TOC wishes.

@antoviaque
Copy link
Contributor Author

@e0d Btw, since it can be tricky sometimes to get the group to take decisions on a topic, it could be a good occasion to describe a formal mechanism here to help with that? For example, something like that could help ensuring we are able to take decisions, after the topic has been discussed:

  • If the proposal contains a decision proposal, it could be submitted to the approval of the TOC during the meeting where it's on the agenda
  • Each TOC member can: approve, abstain or object to the proposed decision
  • The decision with the most approvals and no objection is considered taken.
  • If there are no decision without objection from any TOC member, then the TOC members who have objected to some of the proposed decisions are asked to write an alternative solution.

This way, there would be an easy way to take decisions when there is consensus on what is brought up to the TOC, while leaving the work of drafting a consensual proposal would be left to the community members posting the proposal (if they want a quick decision, they need to make sure there won't be objections to it). On the other side, asking TOC members to write a counter-proposal when they object would ensure people don't object too easily to everything :) and would ensure there is a clear next step when there is no consensus?

@antoviaque antoviaque changed the title docs: OEP 63 - TOC Appeal (Draft) docs: OEP 63 - TOC Arbitration (Draft) May 29, 2023
@kdmccormick
Copy link
Member

For a better name, "TOC Decision" would work for me. "TOC Input" seem weak - if people want to ask for only "input", they can already do that via the forum for example, or asking TOC members directly. Since we are trying to establish a formal decision process for the TOC based on community input/issues, the name should convey that notion imho.

+1


However, some of the decisions can sometimes be complex: lack of consensus, decisions with long-lasting reprecussions. This can result in delaying taking *any* decision, which can be more hurtful than any of the choices.

In this OEP, the TOC defines a process for community members to bring up topics to the board's attention, and request to take a decision about a proposal (an "Appeal").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the comment @nedbat made, I would open the aperture here to provide a mechanism for seeking input, review, advice. I'd change the language of appeal, which Ned noted, can mean override a decision you don't like.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e0d I agree that the original name of appeal did not match well the use case - I replied on this topic to #484 (comment) and modified the proposal to "arbitration". What do you think?

Copy link
Contributor Author

@antoviaque antoviaque Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, based on this follow-up conversation #484 (comment) I've changed it again to @nedbat 's proposal, of "TOC Decision"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- *when an important decision is being deferred and not making a call is causing friction*
- *to focus the community to collaborate on key, shared value, say, investment in maturing LTI*

Specification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also spoke about having a routine process for TOC review and participation in the OEP process. If I remember correctly @georgebabey was going to make a recommendation about that. Should that be considered here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e0d That would definitely be great to have! And I'm happy to include something about this here. @georgebabey would you like to suggest something inline in this PR? If you have some ideas, I can also give a shot at integrating them in the current document.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgebabey Any progress on this?

- Open a discussion in a public place, such as the `forum <discuss.openedx.org/>`_ or using one of the formal decision recording formats such as `OEPs <https://open-edx-proposals.readthedocs.io/en/latest/>`_. The topics presented need to have been discussed in the community before being formally considered by the TOC.
- After public review, post a formal request to appeal to the TOC. This can be done in a forum post or a `github ticket <https://github.com/openedx/wg-coordination/issues/new>`_ mentioning the TOC chair (@e0d). See the format below.
- Core contributors and/or TOC members supporting the appeal reply in the thread to say so
- If the requirements are met, the TOC will schedule the topic for a future meeting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would folks potentially join a TOC meeting to discuss or would that happen "behind closed doors?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e0d Good point - I'm guessing the TOC will still want to have the possibility to do some of the discussion behind closed doors (though there would still be the summary notes published as usual, so it's not fully closed doors), it makes sense for the person who is submitting the request to be able to present it. And if that's a discussion with multiple parties (for example if there is a disagreement on a direction to take), to be fair the presentation would probably have to include the different parties/opinions.

To also keep it async, maybe it could be under the format of being able to submit presentation videos/materials for the TOC to review async? Any party who would like to could submit a video/presentation async in advance of the meeting. The TOC members, when reviewing the materials in advance, could request some of the parties to join the meeting, to ask questions or discuss.

Let me know what you think? If that works for you, I'll add it to the document.

oeps/processes/oep-0063-proc-toc-appeal.rst Outdated Show resolved Hide resolved
@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 11, 2023
oeps/processes/oep-0063-proc-toc-arbitration.rst Outdated Show resolved Hide resolved
oeps/processes/oep-0063-proc-toc-arbitration.rst Outdated Show resolved Hide resolved
oeps/processes/oep-0063-proc-toc-arbitration.rst Outdated Show resolved Hide resolved
oeps/processes/oep-0063-proc-toc-arbitration.rst Outdated Show resolved Hide resolved
oeps/processes/oep-0063-proc-toc-arbitration.rst Outdated Show resolved Hide resolved
oeps/processes/oep-0063-proc-toc-arbitration.rst Outdated Show resolved Hide resolved
oeps/processes/oep-0063-proc-toc-arbitration.rst Outdated Show resolved Hide resolved
oeps/processes/oep-0063-proc-toc-arbitration.rst Outdated Show resolved Hide resolved
===========================================

- Open a discussion in a public place, such as the `forum <discuss.openedx.org/>`_ or using one of the formal decision recording formats such as `OEPs <https://open-edx-proposals.readthedocs.io/en/latest/>`_. The topics presented need to have been discussed in the community before being formally considered by the TOC.
- After public review, post a formal arbitration request to the TOC. This can be done in a forum post or a `github ticket <https://github.com/openedx/wg-coordination/issues/new>`_ mentioning the TOC chair (@e0d). See the format below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always worry about splitting communication and would limit the request to only be via github ticket. We can templatize the request as per your recommendation below. If there is already a discussion in a public place prior to the arbitration request we risk further discussion in the arbitration request if it comes via a forum post.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgebabey That's a good point, it would make sense to make the arbitration request always be a github ticket - besides the split discussion that you mention, it would likely help processing to have a single consistent way to make the request. Maybe the option of the forum post could be replaced by a requirement to notify in the existing public discussion that an arbitration request has been made, and to link to the github ticket representing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgebabey I have implemented this as I was suggesting above - let me know if that works?

@antoviaque
Copy link
Contributor Author

@itsjeyd I have just done a pass - sorry for the delay on this, I was off for a few weeks. For the criteria for the merge, @e0d would likely be the one who can answer it.

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoviaque @itsjeyd I do not need to review further on this. I defer to @e0d 's approval

@itsjeyd
Copy link

itsjeyd commented Oct 24, 2023

@sarina @antoviaque Sounds good, thanks.

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 24, 2023
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 2, 2023
@itsjeyd itsjeyd requested a review from e0d November 2, 2023 09:17
@itsjeyd
Copy link

itsjeyd commented Nov 17, 2023

Hi @e0d, just checking in to see if you'll be able to get back to this PR in the coming days?

@antoviaque antoviaque changed the title docs: OEP 63 - TOC Arbitration (Draft) docs: OEP 63 - TOC Resolution Request (Draft) Dec 6, 2023
@itsjeyd
Copy link

itsjeyd commented Dec 21, 2023

Hi @e0d, just checking in to see what the next steps are for getting this PR over the line?

@itsjeyd
Copy link

itsjeyd commented Jan 25, 2024

@antoviaque @e0d What's the latest status of this PR? Are you still planning on getting it merged?

@antoviaque
Copy link
Contributor Author

@itsjeyd I would definitely still want to get this to the finish line! @e0d Do you want to pick a time to iron this out? https://calendly.com/antoviaque/30min

@itsjeyd
Copy link

itsjeyd commented Apr 22, 2024

Hi @antoviaque and @e0d, any updates here?

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Apr 22, 2024
Copy link
Contributor

@e0d e0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoviaque thanks for you patience. I've taken a final pass through this and think that all of my comments have been addressed. I think we are good to move forward.

@e0d
Copy link
Contributor

e0d commented Apr 29, 2024

@georgebabey did you have any further input you wanted to provide?

@georgebabey
Copy link
Contributor

Also apologies for the delay - I think this is a great starting point and appreciate all the work and revisions @antoviaque! I think we should land this as is, we can always make future improvements based on how people are leveraging the TOC.

@antoviaque
Copy link
Contributor Author

@e0d @georgebabey Thank you for the reviews! And for the improvements you have contributed. It's great to see the TOC take this step to invite interactions with the broader community. Curious to see what the community will make of it!

@itsjeyd FYI ^ I don't have merge rights here so someone else will need to merge the OEP. I can announce it on the forums afterwards.

@antoviaque antoviaque changed the title docs: OEP 63 - TOC Resolution Request (Draft) docs: OEP 63 - TOC Resolution Request Apr 30, 2024
@e0d e0d merged commit 6498803 into openedx:master Apr 30, 2024
@openedx-webhooks
Copy link

@antoviaque 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the oep-63 branch May 15, 2024 09:56
@itsjeyd itsjeyd removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels May 23, 2024
antoviaque added a commit to antoviaque/open-edx-proposals that referenced this pull request Aug 5, 2024
OEP-63 was accepted and merged in openedx#484 but the status of the OEP hasn't been updated.
sarina pushed a commit that referenced this pull request Aug 5, 2024
OEP-63 was accepted and merged in #484 but the status of the OEP hasn't been updated.
davidjoy pushed a commit to davidjoy/open-edx-proposals that referenced this pull request Aug 28, 2024
OEP-63 was accepted and merged in openedx#484 but the status of the OEP hasn't been updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants