Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tagging] "Bare Bones" Taxonomy Detail Page #138

Closed
bradenmacdonald opened this issue Sep 27, 2023 · 3 comments · Fixed by openedx/frontend-app-authoring#655
Closed

[Tagging] "Bare Bones" Taxonomy Detail Page #138

bradenmacdonald opened this issue Sep 27, 2023 · 3 comments · Fixed by openedx/frontend-app-authoring#655

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Sep 27, 2023

"As a content author, I can view an enabled taxonomy's metadata and tags."

Acceptance Criteria

  1. From the Taxonomies List Page [Tagging] Create Taxonomies List Page (in Course Authoring MFE) #104, when a user clicks anywhere on the taxonomy card that's not one of the menus/icons, they will be taken to a stripped-down version of the Taxonomy Detail Page. Here's what the full version will look like:
    Screenshot 2023-09-19 at 5 06 25 PM
  2. For the bare-bones version, just display all tags, expanded. No collapsing/expanding sections. If not all tags can be loaded at once, use "load more" links where necessary or some other simple solution.
  3. The sidebar will display the taxonomy's title and description. Copyright info is not implemented so will come later.
  4. Add an Actions button with "Export taxonomy as JSON" and "Export Taxonomy as CSV" - same functionality as [Tagging] Per-taxonomy menu on Taxonomy List Page #105 but it can now be accessed from this page too. No need to implement other actions - those are different stories.
    Screenshot 2023-09-22 at 10 34 18 AM
  5. Do not implement Keyword filtering for now - that will come in [Tagging] Keyword filtering of a Taxonomy's tags #128
  6. Do not implement "Expand All" for now - that will come in [Tagging] Add "Expand All" button to Taxonomy View #112

Developer Notes

  • The same view will be re-used as the "Edit Taxonomy" view, so design with that in mind.
  • Screenshots above are for convenience - Figma is the most up-to-date source for mockups. The scale of UI elements seen in the screenshots above may be incorrect.
  • We may or may not keep the pagination tweak in-scope for this MVP, but in any case it's a separate ticket - see [Tagging] Improve pagination of Paragon Data Tables #111
  • To make the taxonomy card clickable while preserving a11y, put a "view taxonomy details" link inside the card, make its inner text visible only to screen readers, and use .stretched-link (bootstrap class) to make the link cover the whole card.
@ali-hugo
Copy link

@rpenido Thanks for your work on this! I've just taken a look at this on the sandbox and have a couple of notes:

  • Please change the title of the "Value" column to "Tag name"
  • I have a question about the zebra stripes on the table. When a row is expanded, is it possible to have the background of the expanded section match the background of the parent tag? So in the screenshot below, the gray background behind the tags "Cognitive Abilities", "Communication Abilities", "Verbal Ability" etc would be white to match the background of the "Abilities" parent tag. That way, it's more clear that those sections are related.
Screenshot 2023-11-28 at 14 19 36

CC: @bradenmacdonald

@bradenmacdonald
Copy link
Contributor Author

bradenmacdonald commented Nov 28, 2023

@ali-hugo The first one is an easy fix (added to FAL-3537). For the second one, we're just using the existing "expand" functionality built into Paragon's DataTable, and it doesn't let you control the stripe colors as far as I can see. So it's something we can fix in #155 along with any other major changes, but I don't think we should spend the time on it now before we're confident about what other changes will be needed. I'll add this into #155.

@rpenido
Copy link

rpenido commented Nov 28, 2023

Hi @ali-hugo! Thank you for the input! Let us know if you find more improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants