-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ora mobile responsive #336
base: master
Are you sure you want to change the base?
feat: Ora mobile responsive #336
Conversation
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
cdc486c
to
b422c87
Compare
d3f25d4
to
b422c87
Compare
376eb32
to
e5e4519
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 1085 1087 +2
Branches 166 167 +1
=========================================
+ Hits 1085 1087 +2 ☔ View full report in Codecov by Sentry. |
@CodeWithEmad - would you be able to take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I only have one minor request.
src/containers/ReviewModal/index.jsx
Outdated
@@ -27,9 +27,12 @@ export const ReviewModal = ({ intl }) => { | |||
isOpen, | |||
closeConfirmModalProps, | |||
} = hooks.rendererHooks({ dispatch, intl }); | |||
|
|||
const isMobile = useMediaQuery({ query: '(max-width: 575.98px)' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably provide this via frontend-platform, but while we don't, the standard seems to be what authoring is doing (max 768px):
https://github.com/openedx/frontend-app-authoring/blob/master/src/utils.js#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@arbrandes ready to review |
@vladislavkeblysh, do you mind rebasing on (or merging with) latest master to make testing easier? |
Description
Related Pull Requests
Screenshots before:
Screenshots after: