-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENT-8343] feat: marked skills-quiz strings for i18n #989
Conversation
cd3cc14
to
38a5f7d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
==========================================
- Coverage 84.87% 84.64% -0.23%
==========================================
Files 320 342 +22
Lines 6399 7476 +1077
Branches 1552 1841 +289
==========================================
+ Hits 5431 6328 +897
- Misses 941 1110 +169
- Partials 27 38 +11 ☔ View full report in Codecov by Sentry. |
7c7b0b4
to
97a662e
Compare
28762b3
to
f50acc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just some minor comments regarding updating the descriptions to add more context.
f50acc9
to
19b22e2
Compare
Jira Ticket: https://2u-internal.atlassian.net/browse/ENT-8343
description: Marked skills-quiz strings for i18n
For all changes
Only if submitting a visual change