Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-8343] feat: marked skills-quiz strings for i18n #989

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

mahamakifdar19
Copy link
Contributor

Jira Ticket: https://2u-internal.atlassian.net/browse/ENT-8343
description: Marked skills-quiz strings for i18n

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.64%. Comparing base (d36b78a) to head (19b22e2).
Report is 168 commits behind head on master.

Files Patch % Lines
src/components/skills-quiz/SkillsQuizStepper.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   84.87%   84.64%   -0.23%     
==========================================
  Files         320      342      +22     
  Lines        6399     7476    +1077     
  Branches     1552     1841     +289     
==========================================
+ Hits         5431     6328     +897     
- Misses        941     1110     +169     
- Partials       27       38      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-8343 branch 7 times, most recently from 7c7b0b4 to 97a662e Compare March 4, 2024 13:19
@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-8343 branch 2 times, most recently from 28762b3 to f50acc9 Compare March 5, 2024 12:50
Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just some minor comments regarding updating the descriptions to add more context.

src/components/skills-quiz/SearchCourseCard.jsx Outdated Show resolved Hide resolved
src/components/skills-quiz/SearchPathways.jsx Outdated Show resolved Hide resolved
src/components/skills-quiz/SearchProgramCard.jsx Outdated Show resolved Hide resolved
src/components/skills-quiz/SkillsQuizStepper.jsx Outdated Show resolved Hide resolved
src/components/skills-quiz/SkillsQuizStepper.jsx Outdated Show resolved Hide resolved
src/components/skills-quiz/SkillsQuizStepper.jsx Outdated Show resolved Hide resolved
src/components/skills-quiz/SkillsQuizStepper.jsx Outdated Show resolved Hide resolved
src/components/skills-quiz/SkillsQuizStepper.jsx Outdated Show resolved Hide resolved
src/components/skills-quiz/SkillsQuizStepper.jsx Outdated Show resolved Hide resolved
@mahamakifdar19 mahamakifdar19 merged commit ba735a3 into master Mar 7, 2024
7 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-8343 branch March 7, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants